Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Conan cppflags to CXXFLAGS in make generator #4349

Merged
merged 4 commits into from Jan 21, 2019

Conversation

@danimtb
Copy link
Member

@danimtb danimtb commented Jan 21, 2019

Changelog: Fix: Map cpp_info.cppflags to CONAN_CXXFLAGS in make generator.
Changelog: Fix: Use *_DIRS instead of *_PATHS ending for varaibles generated by the make generator: INCLUDE_DIRS, LIB_DIRS, BIN_DIRS, BUILD_DIRS and RES_DIRS

Docs: conan-io/docs#1037

@tags: slow

  • Refer to the issue that supports this Pull Request: closes #4336
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@danimtb danimtb added this to the 1.12 milestone Jan 21, 2019
@danimtb danimtb requested a review from memsharded Jan 21, 2019
@ghost ghost assigned danimtb Jan 21, 2019
@ghost ghost added the stage: review label Jan 21, 2019
@danimtb
Copy link
Member Author

@danimtb danimtb commented Jan 21, 2019

Not sure if this is a FIX or a BUGFIX, so reviewer please update the changelogs in the description if needed. Thanks! 😄

@danimtb danimtb removed their assignment Jan 21, 2019
@ghost ghost assigned danimtb Jan 21, 2019
@memsharded memsharded merged commit 42f1a1a into conan-io:develop Jan 21, 2019
2 checks passed
@ghost ghost removed the stage: review label Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants