Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: get_cross_building_settings for MSYS #4390

Merged
merged 1 commit into from Jan 29, 2019

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Jan 27, 2019

closes: #4315

Changelog: Fix: get_cross_building_settings for MSYS
Docs: Omit

@tags: slow, svn

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@ghost ghost assigned SSE4 Jan 27, 2019
@ghost ghost added the stage: review label Jan 27, 2019
conans/client/tools/oss.py Outdated Show resolved Hide resolved
conans/test/unittests/client/tools/oss/__init__.py Outdated Show resolved Hide resolved
Signed-off-by: SSE4 <tomskside@gmail.com>
@memsharded memsharded merged commit dac7447 into conan-io:develop Jan 29, 2019
@ghost ghost removed the stage: review label Jan 29, 2019
@memsharded memsharded added this to the 1.12 milestone Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoToolsBuildEnvironment detect incorrect build under MSYS shell
2 participants