Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing regression of graph_info not having root #4458

Merged

Conversation

Projects
None yet
2 participants
@memsharded
Copy link
Contributor

commented Feb 4, 2019

Changelog: Bugfix: GraphInfo parsing of existing graph_info.json files raises KeyError over "root".
Docs: omit

Close #4443
Close #4447

@memsharded memsharded added this to the 1.12.1 milestone Feb 4, 2019

@ghost ghost assigned memsharded Feb 4, 2019

@ghost ghost added the stage: review label Feb 4, 2019

@memsharded memsharded assigned lasote and unassigned memsharded Feb 4, 2019

@lasote
Copy link
Contributor

left a comment

Add a test to parse an old graph_info from 1.11 (or simulate it)

@memsharded

This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2019

That is exactly the test that I have added.

@lasote

lasote approved these changes Feb 4, 2019

@lasote

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2019

The CI is very broken

@ghost ghost assigned memsharded Feb 4, 2019

@memsharded memsharded merged commit 534f973 into conan-io:release/1.12.1 Feb 4, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Feb 4, 2019

@memsharded memsharded deleted the memsharded:hotfix/graph_info_root_error branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.