Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing regression of graph_info not having root #4458

Merged
merged 3 commits into from Feb 4, 2019
Merged

fixing regression of graph_info not having root #4458

merged 3 commits into from Feb 4, 2019

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Feb 4, 2019 •
edited

Changelog: Bugfix: GraphInfo parsing of existing graph_info.json files raises KeyError over "root".
Docs: omit

Close #4443
Close #4447

@memsharded memsharded added this to the 1.12.1 milestone Feb 4, 2019
@ghost ghost assigned memsharded Feb 4, 2019
@ghost ghost added the stage: review label Feb 4, 2019
@memsharded memsharded assigned lasote and unassigned memsharded Feb 4, 2019
lasote
lasote requested changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test to parse an old graph_info from 1.11 (or simulate it)

@memsharded
Copy link
Member Author

That is exactly the test that I have added.

@lasote
Copy link
Contributor

lasote commented Feb 4, 2019

The CI is very broken

@ghost ghost assigned memsharded Feb 4, 2019
@memsharded memsharded merged commit 534f973 into conan-io:release/1.12.1 Feb 4, 2019
@ghost ghost removed the stage: review label Feb 4, 2019
@memsharded memsharded deleted the hotfix/graph_info_root_error branch February 4, 2019 10:08
@memsharded memsharded mentioned this pull request Feb 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasote lasote lasote approved these changes

Assignees

@lasote lasote

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.12.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@memsharded @lasote