fix meson build_type

[ericLemanissier]

Meson's documentation currently mentions default-library option,
but it is a typo, the proper option is default_library

Changelog: Bugfix: meson build type actually reflects recipe shared option
Docs: omit

• Refer to the issue that supports this Pull Request.
• If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
• I've read the Contributing guide.
• I've followed the PEP8 style guides for Python code.
• I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

^{Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.}

[jgsogo]

I'm not sure if this is an error, I've just installed Meson and this is what I get:

⇒  meson --version
0.49.2

⇒  meson setup --help
usage: meson setup [-h]
                   ...
                   [--default-library {shared,static,both}]
                   ...
                   [builddir] [sourcedir]

positional arguments:
  builddir
  sourcedir

optional arguments:
 ....
  --default-library {shared,static,both}
                        Default library type (default: shared).

It looks like default-library is the name of the parameter.

[uilianries]

--default-library is an argument, but the Meson helper uses options instead, -Ddefault-library

If try to build some project, it will see the follow warning: WARNING: Unknown options: "default-library"

Also, the package xkbcommon is a good example, you can see log here

[jgsogo]

You are right, @uilianries. Thanks a lot!

Please, @ericLemanissier, modify the test that is failing to fix it.

Thanks!

[ericLemanissier]

default_library has 8 occurences whereas default-library has only 1, and it is documentation. it looks like a typo to me.

[uilianries]

BTW, should we include libdir on this issue? As you can see, I needed to add for xkbcommon, otherwise the libraries are installer on package_folder/lib//

[jgsogo]

Using arguments it is by default ( --libdir LIBDIR Library directory (default: lib).), but if using options we need to set it, then we would need to set all of them... libdir, libexecdir, bindir, sbindir,... no?

[uilianries]

hmm, you are right, as done for cmake. Only libdir is enough for xkbcommon, but because we only need to install the libraries.

[ericLemanissier]

What would the default be for libexecdir ? meson has 'libexec' as default value
the other defaults are actually good : https://github.com/mesonbuild/meson/blob/master/mesonbuild/coredata.py#L807

[jgsogo]

Here I need to invoke @danimtb, he worked on that for Autotools if I remember it well.

[uilianries]

The same used for CMake: https://github.com/conan-io/conan/blob/develop/conans/client/build/cmake_flags.py#L282

[ericLemanissier]

the typo on default-/_library documentation is fixed upstream: mesonbuild/meson#4897

[danimtb]

As @uilianries referenced above, I followed in autotools the same pattern of cmake. libexecdir definition can be found here like "The directory for installing executable programs to be run by other programs rather than by users" but were actually not making any difference, so to me it should be force to the "bin" directory to be consistent with the other build helpers.

[jgsogo]

Upsss 😓 , this PR should have been merged into develop. I'm going to revert it from master and create a PR to develop. It was my fault... but your code will be in the next release, thanks @ericLemanissier .