Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow an alias to override an existing package #4495

Merged
merged 7 commits into from Feb 11, 2019
Merged

Do not allow an alias to override an existing package #4495

merged 7 commits into from Feb 11, 2019

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Feb 8, 2019 •
edited by lasote

Changelog: Fix: Do not allow an alias to override an existing package
Docs: omit

closes #4423

✅ Do not pass the cache object to the export_alias function.

@revisions: 1

@ghost ghost assigned jgsogo Feb 8, 2019
@ghost ghost added the stage: review label Feb 8, 2019
@jgsogo jgsogo mentioned this pull request Feb 9, 2019
Merged
memsharded
memsharded reviewed Feb 9, 2019
View reviewed changes
conans/client/cmd/export.py Outdated Show resolved Hide resolved
conans/client/cmd/export.py Outdated Show resolved Hide resolved
@memsharded memsharded added this to the 1.13 milestone Feb 9, 2019
@memsharded memsharded assigned memsharded and unassigned jgsogo Feb 11, 2019
@jgsogo
Copy link
Contributor Author

jgsogo commented Feb 11, 2019

That's it, time to review and merge =D

@memsharded memsharded merged commit 32145a8 into conan-io:develop Feb 11, 2019
@ghost ghost removed the stage: review label Feb 11, 2019
@jgsogo jgsogo deleted the fix/alias-existing branch February 11, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasote lasote lasote left review comments

@memsharded memsharded memsharded left review comments

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.13
Development

Successfully merging this pull request may close these issues.

Prevent conan alias from overwriting existing packages
3 participants
@jgsogo @lasote @memsharded