Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow an alias to override an existing package #4495

Merged
merged 7 commits into from Feb 11, 2019

Conversation

@jgsogo
Copy link
Member

@jgsogo jgsogo commented Feb 8, 2019

Changelog: Fix: Do not allow an alias to override an existing package
Docs: omit

closes #4423

Do not pass the cache object to the export_alias function.

@revisions: 1

@ghost ghost assigned jgsogo Feb 8, 2019
@ghost ghost added the stage: review label Feb 8, 2019
conans/client/cmd/export.py Outdated Show resolved Hide resolved
conans/client/cmd/export.py Outdated Show resolved Hide resolved
@memsharded memsharded added this to the 1.13 milestone Feb 9, 2019
@memsharded memsharded assigned memsharded and unassigned jgsogo Feb 11, 2019
@jgsogo
Copy link
Member Author

@jgsogo jgsogo commented Feb 11, 2019

That's it, time to review and merge =D

@memsharded memsharded merged commit 32145a8 into conan-io:develop Feb 11, 2019
2 checks passed
@ghost ghost removed the stage: review label Feb 11, 2019
@jgsogo jgsogo deleted the fix/alias-existing branch Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants