Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for using @ in conanfile.txt imports #4539

Merged

Conversation

Projects
None yet
3 participants
@memsharded
Copy link
Contributor

commented Feb 18, 2019

Changelog: Bugfix: Fixed problem with conanfile.txt [imports] sections using the '@' character.
Docs: conan-io/docs#1078

Close #4524

There was a problem with folders using "@" and not extra arguments being specified, it failed because the rsplit(, 1) was splitting it. Possibilities:

  • Use spaces <blank>@<blank> to split path<->args. Could break some users if they put @folders=True. But simple, will work without needing a trailing @.
  • Force users with @ in their pathnames to define a trailing @, even if empty (implemented solution).
  • Do a full fledged parser that regexs over the folders=True, etc. patterns (too complex for the value).

@ghost ghost assigned memsharded Feb 18, 2019

@ghost ghost added the stage: review label Feb 18, 2019

Show resolved Hide resolved conans/client/loader_txt.py Outdated

@memsharded memsharded added this to the 1.12.3 milestone Feb 18, 2019

@memsharded memsharded removed their assignment Feb 18, 2019

@lasote lasote merged commit 2d47ea2 into conan-io:release/1.12.3 Feb 18, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Feb 18, 2019

@memsharded memsharded deleted the memsharded:hotfix/imports_at_char_error branch Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.