New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check SettingsItem return type #4571

Merged

lasote merged 4 commits into conan-io:develop from memsharded:feature/settings_item_return

Feb 26, 2019

Member

memsharded commented Feb 19, 2019 •

edited

Changelog: Bugfix: Avoid str(self.settings.xxx) crash when the value is None.
Docs: conan-io/docs#1089

Testing #4562


          check SettingsItem return type

3391f21

ghost assigned memsharded

ghost added the stage: review label

memsharded added 3 commits

February 19, 2019 16:16


          added test

ca1549f


          added test get_safe()

97b505c


          Merge branch 'develop' into feature/settings_item_return

5abfeb3

memsharded added this to the 1.13 milestone

memsharded marked this pull request as ready for review

February 25, 2019 17:55

memsharded assigned lasote and unassigned memsharded

lasote merged commit 5a15fca into conan-io:develop

ghost removed the stage: review label

memsharded deleted the feature/settings_item_return branch

February 26, 2019 11:59

memsharded mentioned this pull request

getattr(self.settings, "build_type", "") should return "" instead of raising ConanException #4562

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment