Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check SettingsItem return type #4571

Merged
merged 4 commits into from Feb 26, 2019

Conversation

Projects
None yet
2 participants
@memsharded
Copy link
Contributor

commented Feb 19, 2019

Changelog: Bugfix: Avoid str(self.settings.xxx) crash when the value is None.
Docs: conan-io/docs#1089

Testing #4562

@ghost ghost assigned memsharded Feb 19, 2019

@ghost ghost added the stage: review label Feb 19, 2019

memsharded added some commits Feb 19, 2019

@memsharded memsharded added this to the 1.13 milestone Feb 25, 2019

@memsharded memsharded marked this pull request as ready for review Feb 25, 2019

@memsharded memsharded assigned lasote and unassigned memsharded Feb 25, 2019

@lasote lasote merged commit 5a15fca into conan-io:develop Feb 26, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Feb 26, 2019

@memsharded memsharded deleted the memsharded:feature/settings_item_return branch Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.