Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
fixing module.__file__ is None in py3 #4669
jgsogo left a comment
This PR solves the problem reported by the user, but it is also introducing a test I do not agree with:
That test requires a
Nevertheless I agree with this PR, it fixes an issue, but I think we should have a look to some other corner cases proposed in #4664.
Mar 6, 2019
That is valid and currently used by companies. Pure python. About the global state, not so important but indeed a performance issue.
Yes, it is a valid use case, @lasote, but there are two things that are incompatible when loading dynamically python files:
I think that both use cases are licit, but if I have to choose, I prefer reproducibility and consistency over sharing a global variable (and being afraid of not being using the one I pretended to use).
The problem comes with modules that do not belong to recipes, like globally installed python libraries. These cannot be put under