Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add support for CMake generator platform #4708

Merged
merged 2 commits into from Mar 19, 2019

Conversation

@SSE4
Copy link
Contributor

@SSE4 SSE4 commented Mar 10, 2019

Changelog: Fix: add support for CMake generator platform
Docs: conan-io/docs#1125
tags: @slow @svn
closes #4707
closes #4755

Signed-off-by: SSE4 <tomskside@gmail.com>
@ghost ghost assigned SSE4 Mar 10, 2019
@ghost ghost added the stage: review label Mar 10, 2019
@lasote lasote added this to the 1.14 milestone Mar 11, 2019
conans/client/build/cmake.py Show resolved Hide resolved
conans/test/unittests/client/build/cmake_test.py Outdated Show resolved Hide resolved
Signed-off-by: SSE4 <tomskside@gmail.com>
Copy link
Contributor

@lasote lasote left a comment

No way this is a Docs: omit. The code is ok, but the docs are indeed needed. Give always a priority to complete a pending PR work.

@SSE4
Copy link
Contributor Author

@SSE4 SSE4 commented Mar 18, 2019

added docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants