Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add support for CMake generator platform #4708

Merged
merged 2 commits into from Mar 19, 2019

Conversation

Projects
None yet
3 participants
@SSE4
Copy link
Contributor

commented Mar 10, 2019

Changelog: Fix: add support for CMake generator platform
Docs: conan-io/docs#1125
tags: @slow @svn
closes #4707
closes #4755

- add support for CMake generator platform
Signed-off-by: SSE4 <tomskside@gmail.com>

@ghost ghost assigned SSE4 Mar 10, 2019

@ghost ghost added the stage: review label Mar 10, 2019

@lasote lasote added this to the 1.14 milestone Mar 11, 2019

- add more tests
Signed-off-by: SSE4 <tomskside@gmail.com>
@lasote
Copy link
Contributor

left a comment

No way this is a Docs: omit. The code is ok, but the docs are indeed needed. Give always a priority to complete a pending PR work.

@SSE4

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

added docs

@lasote lasote merged commit 439e6c4 into conan-io:develop Mar 19, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.