Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supporting multiple conan-config-install and source/target subfolders #4709

Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Mar 11, 2019

Changelog: Feature: Implement --source-folder and --target-folder to conan config install command to select subfolder to install from the source origin, and also the destination folder within the cache.
Docs: conan-io/docs#1131

Close #4603

@ghost ghost assigned memsharded Mar 11, 2019
@ghost ghost added the stage: review label Mar 11, 2019
@memsharded memsharded added this to the 1.14 milestone Mar 11, 2019
@memsharded memsharded assigned lasote and unassigned memsharded Mar 11, 2019
@ghost ghost assigned memsharded Mar 11, 2019
@memsharded memsharded removed their assignment Mar 15, 2019

install_subparser.add_argument("--verify-ssl", nargs="?", default="True",
help='Verify SSL connection when downloading file')
install_subparser.add_argument("--type", "-t", choices=["git"],
help='Type of remote config')
install_subparser.add_argument("--args", "-a",
help='String with extra arguments for "git clone"')
install_subparser.add_argument("-sf", "--source-folder",
help='Install files from that path')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better: Install files from a concrete source folder in the specified origin

from conans.util.files import mkdir, rmdir, walk, save


def migrate_config_install(cache):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to have this on the migrations module.

@ghost ghost assigned memsharded Mar 15, 2019
@memsharded memsharded merged commit 862c76a into conan-io:develop Mar 20, 2019
@ghost ghost removed the stage: review label Mar 20, 2019
@memsharded memsharded deleted the feature/multiple_config_install branch March 20, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants