Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude tests from distribution #4713

Merged
merged 1 commit into from Mar 14, 2019
Merged

Exclude tests from distribution #4713

merged 1 commit into from Mar 14, 2019

Conversation

lasote
Copy link
Contributor

@lasote lasote commented Mar 11, 2019

Changelog: Fix: Do not distribute the tests in the python package nor in the installers.
Docs: omit.

Closes #4563

@ghost ghost assigned lasote Mar 11, 2019
@ghost ghost added the stage: review label Mar 11, 2019
@lasote lasote added this to the 1.14 milestone Mar 11, 2019
@lasote lasote assigned memsharded and unassigned lasote Mar 11, 2019
@jgsogo jgsogo mentioned this pull request Mar 14, 2019
Merged
@memsharded memsharded merged commit 79a9ec1 into conan-io:develop Mar 14, 2019
@ghost ghost removed the stage: review label Mar 14, 2019
@uilianries
Copy link
Member

Hi!

Is there some way to distribute dynamically? Like using pip install conan[test]?

I'm asking because CPT uses Conan tests components on its tests. Now CPT is broken on CI:

https://travis-ci.org/uilianries/conan-package-tools/jobs/506369084

@uilianries uilianries mentioned this pull request Mar 14, 2019
Merged
@lasote
Copy link
Contributor Author

lasote commented Mar 14, 2019

I've no idea...

@uilianries
Copy link
Member

We are not the first one with the same problem ... I asked in StackOverflow and a person there suggested a solution.

https://stackoverflow.com/questions/55169296/how-to-distribute-specific-files-using-setuptools?noredirect=1#comment97078163_55169296

@uilianries uilianries mentioned this pull request Mar 14, 2019
Closed
3 tasks
@lasote
Copy link
Contributor Author

lasote commented Mar 15, 2019

I've opened a new PR #4750 proposing excluding the tests but keeping the test utils.

@uilianries
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lasote @uilianries @memsharded