Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude tests from distribution #4713

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
3 participants
@lasote
Copy link
Contributor

commented Mar 11, 2019

Changelog: Fix: Do not distribute the tests in the python package nor in the installers.
Docs: omit.

Closes #4563

@ghost ghost assigned lasote Mar 11, 2019

@ghost ghost added the stage: review label Mar 11, 2019

@lasote lasote added this to the 1.14 milestone Mar 11, 2019

@lasote lasote assigned memsharded and unassigned lasote Mar 11, 2019

@jgsogo jgsogo referenced this pull request Mar 14, 2019

Merged

warnings as errors #4548

@memsharded memsharded merged commit 79a9ec1 into conan-io:develop Mar 14, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Mar 14, 2019

@uilianries

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

Hi!

Is there some way to distribute dynamically? Like using pip install conan[test]?

I'm asking because CPT uses Conan tests components on its tests. Now CPT is broken on CI:

https://travis-ci.org/uilianries/conan-package-tools/jobs/506369084

@lasote

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

I've no idea...

@uilianries

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

We are not the first one with the same problem ... I asked in StackOverflow and a person there suggested a solution.

https://stackoverflow.com/questions/55169296/how-to-distribute-specific-files-using-setuptools?noredirect=1#comment97078163_55169296

@uilianries uilianries referenced this pull request Mar 14, 2019

Closed

CPT won't work with Conan 1.14.0-dev #4746

1 of 3 tasks complete
@lasote

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

I've opened a new PR #4750 proposing excluding the tests but keeping the test utils.

@uilianries

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.