Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recursive build requires #4783

Merged

Conversation

Projects
None yet
3 participants
@memsharded
Copy link
Contributor

commented Mar 20, 2019

Changelog: Bugfix: Solved bug with build-requires transitive build-requires
Changelog: Bugfix: Fixed workspace crash when no layout was specified
Changelog: Bugfix: Do not generate multiple add_subdirectories() for workspaces build-requires

Docs: omit

Close #4752

@tags: slow

@ghost ghost assigned memsharded Mar 20, 2019

@ghost ghost added the stage: review label Mar 20, 2019

@memsharded memsharded added this to the 1.13.2 milestone Mar 20, 2019

@jgsogo

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

This PR also fixes/closes/invalidates #3639, with the logic implemented here you cannot repackage using the same name as the build_requires one, it raises with "ERROR: Loop detected: 'my_conanfile_base/1.0.23@lasote/testing' requires 'my_conanfile_base/1.0@lasote/testing' which is an ancestor too". Same if using requires instead of build_requires.

Previously behavior was different:

  • for build_requires both libraries were compiled, even if the build_Requires was already available
  • for requires it was entering an infinite loop.

Also, when this PR gets merged, we should revisit #3759 and #3822 (not sure if those will be open questions now).

@lasote lasote merged commit b39b68a into conan-io:release/1.13.2 Mar 21, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Mar 21, 2019

@memsharded memsharded deleted the memsharded:fix/recursive_build_requires branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.