Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show profile name when detect a new one (#4818) #4824

Merged
merged 7 commits into from Mar 26, 2019

Conversation

Projects
None yet
5 participants
@uilianries
Copy link
Member

commented Mar 25, 2019

The warning message will show the correct profile name instead of printing only "default".

Changelog: Fix: Show the correct profile name when detect a new one (#4818)
Docs: Omit

fixes #4818

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

#4818 Show profile name when detect a new one
- Detect warning message will show the correct profile name instead of
  print only "default".

Signed-off-by: Uilian Ries <uilianries@gmail.com>

@ghost ghost assigned uilianries Mar 25, 2019

@ghost ghost added the stage: review label Mar 25, 2019

Show resolved Hide resolved conans/test/functional/command/profile_test.py Outdated
@memsharded

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

Please check the broken tests.

#4818 Fix tests for detect profile
Signed-off-by: Uilian Ries <uilianries@gmail.com>

@lasote lasote added this to the 1.14 milestone Mar 25, 2019

@lasote lasote assigned danimtb and unassigned uilianries Mar 26, 2019

#4818 Retify profile path
- When the profile name is a file path, it should exclude
  the dir path and show only the profile name

Signed-off-by: Uilian Ries <uilianries@gmail.com>

@ghost ghost assigned uilianries Mar 26, 2019

Show resolved Hide resolved conans/client/conf/detect.py Outdated
Show resolved Hide resolved conans/test/functional/command/profile_test.py Outdated
#4818 Dynamic profile path
- Print profile name and profile path based on its path;

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@CLAassistant

This comment has been minimized.

Copy link

commented Mar 26, 2019

CLA assistant check
All committers have signed the CLA.

@danimtb
Copy link
Member

left a comment

Looking good 👍

Show resolved Hide resolved conans/client/conf/detect.py Outdated

uilianries added some commits Mar 26, 2019

#4818 Use profile file path
- When looking for default settings, use the profile
  file path, instead of creating a path by its name

Signed-off-by: Uilian Ries <uilianries@gmail.com>
#4818 Fix default profile path
- Cache should consume the default profile path.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@memsharded
Copy link
Contributor

left a comment

That's it :) :) :)

@uilianries

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

The testing service is out. Let's wait ;)

@lasote

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

Service back but still failing

@uilianries

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

This time is my fault. I didn't check on Windows.

#4818 Fix profile path on Windows
- It doesn't matter which platform is running, detect_default_settings
  does not parse the path.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

All green again! 💚

@memsharded memsharded merged commit ae951f6 into conan-io:develop Mar 26, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.