Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/replace check output #4854

Merged
merged 14 commits into from Mar 28, 2019
Merged

Conversation

@lasote
Copy link
Contributor

@lasote lasote commented Mar 28, 2019

Changelog: Bugfix: Fixed recipe revision detection when some error output or unexpected output was printed to the stdout running the git command.
Docs: omit

Will open an engineering issue to replace ALL the previous subprocess.check_output (and other original ways to do the same) to use this.

This might collaterally solve #4850 too

@ghost ghost assigned lasote Mar 28, 2019
@ghost ghost added the stage: review label Mar 28, 2019
@lasote lasote added this to the 1.14 milestone Mar 28, 2019
@lasote lasote requested a review from memsharded Mar 28, 2019
@lasote lasote assigned memsharded and unassigned lasote Mar 28, 2019
@ghost ghost assigned lasote Mar 28, 2019
@lasote lasote removed their assignment Mar 28, 2019
@ghost ghost assigned lasote Mar 28, 2019
@lasote lasote marked this pull request as ready for review Mar 28, 2019
@lasote lasote merged commit 1548364 into conan-io:develop Mar 28, 2019
2 checks passed
@ghost ghost removed the stage: review label Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants