Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude conanfile.py from bare package copy #4892

Closed
wants to merge 2 commits into from

Conversation

@jgsogo
Copy link
Member

@jgsogo jgsogo commented Apr 2, 2019

Changelog: Fix: Example bare package recipe excludes conanfile.py from copy
Docs: omit

closes #4829

@ghost ghost assigned jgsogo Apr 2, 2019
@ghost ghost added the stage: review label Apr 2, 2019
@jgsogo jgsogo marked this pull request as ready for review Apr 2, 2019
@jgsogo jgsogo requested a review from danimtb Apr 2, 2019
@jgsogo jgsogo added this to the 1.15 milestone Apr 2, 2019
@danimtb
Copy link
Member

@danimtb danimtb commented Apr 3, 2019

As talked, it seems the issue is not that simple and something is messed up with the different input folders of the command

@jgsogo
Copy link
Member Author

@jgsogo jgsogo commented Apr 3, 2019

Yes, sure, I didn't pay attention to the help message under the --package-folder argument: "it won't call the recipe 'package()' method". I'll try to make it more visible.

@jgsogo
Copy link
Member Author

@jgsogo jgsogo commented Apr 3, 2019

The error/improvement is in the docs, not in the code.

@jgsogo jgsogo closed this Apr 3, 2019
@ghost ghost removed the stage: review label Apr 3, 2019
@jgsogo jgsogo deleted the fix/4829-bare-package branch Apr 3, 2019
@jgsogo jgsogo restored the fix/4829-bare-package branch Apr 3, 2019
@jgsogo jgsogo deleted the fix/4829-bare-package branch Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants