Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print an error in both Py2 and Py3 when no params are entered for commands with subarguments #4902

Merged
merged 3 commits into from Apr 11, 2019
Merged

Print an error in both Py2 and Py3 when no params are entered for commands with subarguments #4902

merged 3 commits into from Apr 11, 2019

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Apr 4, 2019 •
edited by lasote

Changelog: Fix: Adding subparsers.required = True makes both Py2 and Py3 print an error when no arguments are entered in commands that have subarguments
Docs: omit

Fixes #4816

Bug in python: https://bugs.python.org/issue9253#msg186387

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@jgsogo jgsogo added this to the 1.15 milestone Apr 4, 2019
@jgsogo jgsogo requested a review from lasote April 4, 2019 12:26
memsharded
memsharded reviewed Apr 4, 2019
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a test for this behavior, and guarantee it doesn't break in the future.

@jgsogo
Copy link
Contributor

jgsogo commented Apr 10, 2019

Please, merge develop branch and fix conflicts 😸

@jgsogo jgsogo requested a review from memsharded April 10, 2019 19:13
@memsharded
Copy link
Member

Good, thanks!

@memsharded memsharded merged commit 9fc4686 into conan-io:develop Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasote lasote Awaiting requested review from lasote

@memsharded memsharded Awaiting requested review from memsharded

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.15
Development

Successfully merging this pull request may close these issues.

Py3: Commands with subarguments do and say nothing if no params are entered
4 participants
@czoido @CLAassistant @jgsogo @memsharded