Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print an error in both Py2 and Py3 when no params are entered for commands with subarguments #4902

Merged
merged 3 commits into from Apr 11, 2019

Conversation

Projects
None yet
4 participants
@czoido
Copy link
Contributor

commented Apr 4, 2019

Changelog: Fix: Adding subparsers.required = True makes both Py2 and Py3 print an error when no arguments are entered in commands that have subarguments
Docs: omit

Fixes #4816

Bug in python: https://bugs.python.org/issue9253#msg186387

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.
@CLAassistant

This comment has been minimized.

Copy link

commented Apr 4, 2019

CLA assistant check
All committers have signed the CLA.

@jgsogo jgsogo added this to the 1.15 milestone Apr 4, 2019

@jgsogo jgsogo requested a review from lasote Apr 4, 2019

@memsharded
Copy link
Contributor

left a comment

It would be nice to have a test for this behavior, and guarantee it doesn't break in the future.

@jgsogo

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Please, merge develop branch and fix conflicts 😸

@jgsogo jgsogo requested a review from memsharded Apr 10, 2019

@memsharded

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

Good, thanks!

@memsharded memsharded merged commit 9fc4686 into conan-io:develop Apr 11, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.