Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not find modules for cmake_find_package_multi #4995

Merged
merged 1 commit into from Apr 17, 2019
Merged

do not find modules for cmake_find_package_multi #4995

merged 1 commit into from Apr 17, 2019

Conversation

lasote
Copy link
Contributor

@lasote lasote commented Apr 17, 2019 •
edited by memsharded

Changelog: Bugfix: Bug in cmake_find_package_multi caused CMake to find incorrect modules in CMake modules paths when only Config files should be taken into account.
Docs: omit

Close #4994

@lasote lasote added this to the 1.14.4 milestone Apr 17, 2019
@lasote lasote requested a review from memsharded April 17, 2019 12:17
@ghost ghost assigned lasote Apr 17, 2019
@ghost ghost added the stage: review label Apr 17, 2019
memsharded
memsharded approved these changes Apr 17, 2019
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky cmake, as usual...

@memsharded memsharded merged commit 4490b7c into conan-io:release/1.14.4 Apr 17, 2019
@ghost ghost removed the stage: review label Apr 17, 2019
@memsharded memsharded mentioned this pull request Apr 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees

@lasote lasote

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.14.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lasote @memsharded