Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try visual_studio generator with backslashes #5003

Merged
merged 5 commits into from Apr 26, 2019
Merged

try visual_studio generator with backslashes #5003

merged 5 commits into from Apr 26, 2019

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Apr 17, 2019 •
edited

Changelog: Fix: Use back slashes for visual_studio generator instead of forward slashes
Docs: omit

NOTE: This might be a bit risky, as visual_studio is not that thoroughly tested. Might need extra manual check.

@tags: slow

Close #4969

@ghost ghost assigned memsharded Apr 17, 2019
@ghost ghost added the stage: review label Apr 17, 2019
@memsharded memsharded mentioned this pull request Apr 17, 2019
Closed
3 tasks
@memsharded memsharded added this to the 1.15 milestone Apr 17, 2019
@lasote
Copy link
Contributor

lasote commented Apr 22, 2019

Failing test, please check: visual_studio_test.py", line 60

@memsharded
Copy link
Member Author

Thanks, fixed, please review again

@memsharded memsharded assigned lasote and unassigned memsharded Apr 23, 2019
@lasote lasote merged commit f4d680b into conan-io:develop Apr 26, 2019
@ghost ghost removed the stage: review label Apr 26, 2019
@memsharded memsharded deleted the feature/visual_studio_backslash branch April 28, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lasote lasote

Labels
None yet
Projects
None yet
Milestone
1.15
Development

Successfully merging this pull request may close these issues.

Visual Studio Generator: PATH variable not correct
2 participants
@memsharded @lasote