Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try visual_studio generator with backslashes #5003

Merged
merged 5 commits into from Apr 26, 2019

Conversation

Projects
None yet
2 participants
@memsharded
Copy link
Contributor

commented Apr 17, 2019

Changelog: Fix: Use back slashes for visual_studio generator instead of forward slashes
Docs: omit

NOTE: This might be a bit risky, as visual_studio is not that thoroughly tested. Might need extra manual check.

@tags: slow

Close #4969

@ghost ghost assigned memsharded Apr 17, 2019

@ghost ghost added the stage: review label Apr 17, 2019

@memsharded memsharded referenced this pull request Apr 17, 2019

Closed

Visual Studio Generator: PATH variable not correct #4969

3 of 3 tasks complete

@memsharded memsharded added this to the 1.15 milestone Apr 17, 2019

@lasote

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

Failing test, please check: visual_studio_test.py", line 60

@memsharded

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

Thanks, fixed, please review again

@memsharded memsharded assigned lasote and unassigned memsharded Apr 23, 2019

@lasote lasote merged commit f4d680b into conan-io:develop Apr 26, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Apr 26, 2019

@memsharded memsharded deleted the memsharded:feature/visual_studio_backslash branch Apr 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.