Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check_compiler_version macro to handle latest Visual Studios #5041

Merged
merged 3 commits into from Apr 29, 2019

Conversation

Projects
None yet
4 participants
@jmarrec
Copy link
Contributor

commented Apr 26, 2019

Changelog: Fix: A simple addition to ensure right compiler version is found on windows.
Docs: omit

(I have read the contributing guide. It's such a small thing that I didn't bother to create an issue first for this though).

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code: N/A
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one: N/A

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@CLAassistant

This comment has been minimized.

Copy link

commented Apr 26, 2019

CLA assistant check
All committers have signed the CLA.

@memsharded

This comment has been minimized.

Copy link
Contributor

commented Apr 28, 2019

Hi @jmarrec

Thanks for trying to contribute this PR.
The tests are broken, you can see the output of CI here: https://conan-ci.jfrog.info/blue/organizations/jenkins/ConanTestSuite/detail/PR-5041/1/pipeline. You can also try to run the tests locally with nosetests.

The problem is that you are using lexicographic string compare with STRLESS and you probably need to use numerical or version comparison in order to achieve the expected result. Please have a look at it, thanks!

@jmarrec

This comment has been minimized.

Copy link
Contributor Author

commented Apr 28, 2019

Hi, yeah I did see the failures earlier. Will look when back at a computer. What's the earliest cmake you intend to support? (Some functions aren't available in older cmake versions (eg strless_equal, not that I intend to use this one in particular)).I see some doc examples with 2.8, is that so?

@memsharded

This comment has been minimized.

Copy link
Contributor

commented Apr 28, 2019

Hi.
Yes, we are still trying to support CMake down to 2.8.12. This might change in the future, but so far, we are maintaining ourselves a few hacks to be compatible. Unfortunately there are still some users that can't upgrade cmake from that version easily.

@lasote lasote added this to the 1.15 milestone Apr 29, 2019

@memsharded

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

Great, thanks for the contribution

@memsharded memsharded merged commit 6d3282f into conan-io:develop Apr 29, 2019

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@jmarrec jmarrec deleted the jmarrec:hotfix/msvc branch Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.