Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix migration #5103

Merged

Conversation

Projects
None yet
2 participants
@memsharded
Copy link
Contributor

commented May 6, 2019

Changelog: Fix: Fix migration of registry.json|txt file including reference to non existing remotes.
Docs: omit

Close #5099

@lasote it is necessary to find a way to fix the migrations settings.yml before closing the release, otherwise both develop and all patch releases are broken initially,

@ghost ghost assigned memsharded May 6, 2019

@ghost ghost added the stage: review label May 6, 2019

@memsharded memsharded added this to the 1.15.1 milestone May 6, 2019

@lasote

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

Yep. It should be done before pushing develop after closing the release. I forgot it. It is hardly automated. But I'm absolutely glad it breaks the build, that's the purpose, we just need to be more aware of the CI screen.

About the patch releases, I think it might be correct to be broken initially. I prefer that to introduce a not tested commit or outdated settings by mistake. That variable shouldn't be introduced until the release is frozen.

@lasote lasote merged commit c1375a0 into conan-io:release/1.15.1 May 7, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label May 7, 2019

@memsharded memsharded deleted the memsharded:hotfix/remote_metadata_migration branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.