fix migration #5103
Merged
fix migration #5103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Yep. It should be done before pushing develop after closing the release. I forgot it. It is hardly automated. But I'm absolutely glad it breaks the build, that's the purpose, we just need to be more aware of the CI screen. About the patch releases, I think it might be correct to be broken initially. I prefer that to introduce a not tested commit or outdated settings by mistake. That variable shouldn't be introduced until the release is frozen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Fix migration of registry.json|txt file including reference to non existing remotes.
Docs: omit
Close #5099
@lasote it is necessary to find a way to fix the migrations settings.yml before closing the release, otherwise both develop and all patch releases are broken initially,