Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing symlink copy if src folder is a symlink (#5114) #5125

Merged

Conversation

@danielroedl
Copy link
Contributor

@danielroedl danielroedl commented May 10, 2019

Changelog: Fix: self.copy with symlinks=True does not copy symlink if the .conan directory is a symlink #5114
Docs: omit

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@CLAassistant
Copy link

@CLAassistant CLAassistant commented May 10, 2019

CLA assistant check
All committers have signed the CLA.

@lasote lasote added this to the 1.16 milestone May 21, 2019
lasote
lasote approved these changes May 21, 2019
@lasote lasote requested a review from memsharded May 21, 2019
@memsharded memsharded merged commit 9cf2eee into conan-io:develop May 23, 2019
2 checks passed
@memsharded
Copy link
Member

@memsharded memsharded commented May 23, 2019

thanks for contributing this!
Merged, will be released in next Conan 1.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants