Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy generator: use copy() rather than copyfile() #5136

Merged
merged 6 commits into from May 23, 2019

Conversation

@tmwa
Copy link
Contributor

@tmwa tmwa commented May 13, 2019

fixes #5135

Changelog: Bugfix: Use copy() for deploy generator so that permissions of files are preserved. Required if you want to use the deploy generator to deploy executables.

Docs: omit

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.
@CLAassistant
Copy link

@CLAassistant CLAassistant commented May 13, 2019

CLA assistant check
All committers have signed the CLA.

@danimtb
Copy link
Member

@danimtb danimtb commented May 14, 2019

It would deserve an integration test with the use case of the original issue

@lasote lasote added this to the 1.16 milestone May 14, 2019
@tmwa
Copy link
Contributor Author

@tmwa tmwa commented May 17, 2019

Personally I don't have a lot of time to look into how to add and write an integration test. The change is small enough to do without imo.

@danimtb
Copy link
Member

@danimtb danimtb commented May 17, 2019

@tmwa no problem, I would contribute the test for you 😄

@danimtb danimtb requested a review from lasote May 21, 2019
@memsharded memsharded merged commit a8eccd5 into conan-io:develop May 23, 2019
2 checks passed
@memsharded
Copy link
Member

@memsharded memsharded commented May 23, 2019

Merged! Thanks @tmwa for the contribution, it will be released in next Conan 1.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants