New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy generator: use copy() rather than copyfile() #5136
Merged
memsharded
merged 6 commits into
conan-io:develop
from
tmwa:feature/deploy_gen_permissions
May 23, 2019
Merged
deploy generator: use copy() rather than copyfile() #5136
memsharded
merged 6 commits into
conan-io:develop
from
tmwa:feature/deploy_gen_permissions
May 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danimtb
approved these changes
May 14, 2019
It would deserve an integration test with the use case of the original issue |
Personally I don't have a lot of time to look into how to add and write an integration test. The change is small enough to do without imo. |
@tmwa no problem, I would contribute the test for you 😄 |
memsharded
approved these changes
May 21, 2019
memsharded
reviewed
May 21, 2019
Merged! Thanks @tmwa for the contribution, it will be released in next Conan 1.16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5135
Changelog: Bugfix: Use
copy()
for deploy generator so that permissions of files are preserved. Required if you want to use the deploy generator to deploy executables.Docs: omit
develop
branch, documenting this one.