Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove sys reqs wildcard #5176

Merged
merged 8 commits into from May 28, 2019

Conversation

@Minimonium
Copy link
Contributor

@Minimonium Minimonium commented May 19, 2019

Changelog: Feature: Allow using wildcards to remove system requirements sentinel from cache.
Docs: conan-io/docs#1294

Fixes #4478

It handles the ref case to keep the old behaviour but changes the error message when no pattern or reference has been passed (to highlight that wildcards allowed too now).

I've removed this line:

ref = self._check_query_parameter_and_get_reference(args.pattern_or_reference, args.query)

Since the reference is not needed at this scope anymore, I'm not sure that the query check is still needed since it's the only case of using this function in the program. Consider removing the static function too.

conans/client/cache/cache.py Outdated Show resolved Hide resolved
@lasote lasote added this to the 1.16 milestone May 20, 2019
@Minimonium
Copy link
Contributor Author

@Minimonium Minimonium commented May 23, 2019

So, I have left the remove_system_reqs function in the cache to handle errors as close as possible to the call, I have pulled up the branching to the command and handling to the conan_api.

@lasote lasote requested a review from jgsogo May 24, 2019
Copy link
Member

@jgsogo jgsogo left a comment

Good! Just a change you couldn't be aware of. Thanks for your contribution!

conans/client/conan_api.py Outdated Show resolved Hide resolved
Copy link
Member

@danimtb danimtb left a comment

thanks for the contribution! Please check the suggestion above 😄

@danimtb
Copy link
Member

@danimtb danimtb commented May 27, 2019

@Minimonium please solve the conflicts in the files above and it would be ready for merge. Thanks!

jgsogo
jgsogo approved these changes May 27, 2019
Copy link
Member

@jgsogo jgsogo left a comment

Waiting for those conflicts to be solved. Thanks!

conans/client/conan_api.py Show resolved Hide resolved
jgsogo
jgsogo approved these changes May 27, 2019
@danimtb
Copy link
Member

@danimtb danimtb commented May 27, 2019

I have just realized that the documentation update is missing in this PR. An example at the bottom of this page: https://docs.conan.io/en/latest/reference/commands/misc/remove.html

@Minimonium
Copy link
Contributor Author

@Minimonium Minimonium commented May 27, 2019

Docs: conan-io/docs#1294

@danimtb danimtb merged commit edab446 into conan-io:develop May 28, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants