Detect System package name by recipe settings (#5026) #5215

uilianries · 2019-05-24T20:22:06Z

Changelog: Feature: SystemPackageTool platform detection (#5026)
Docs: conan-io/docs#1291

Refer to the issue that supports this Pull Request.
If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
I've read the Contributing guide.
I've followed the PEP8 style guides for Python code.
I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

^{Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.}

- Each package manages has a specific prefix/suffix to deal with architectures. - Some package managers (e.g brew) do not provide multi-arch support, only an universal option. Signed-off-by: Uilian Ries <uilianries@gmail.com>

- Validate yum and apt when installing x86 Signed-off-by: Uilian Ries <uilianries@gmail.com>

danimtb

Thanks for your contribution!
Although I have to say that this is the typical thing that never hammers all the nails at once 🔨 🔨

SSE4 · 2019-05-27T10:59:47Z

hi @uilianries
do I right understand that it will always transform package name? e.g. wayland-protocols becomes wayland-protocols:i386 or whatever? in that case, it would be breaking for some packages, as wayland-protocols for instance have no arch packages, and it has only wayland-protocols:all. https://packages.debian.org/sid/wayland-protocols

lasote · 2019-05-27T11:43:00Z

Probably we need an opt-out at install to escape the magic

uilianries · 2019-05-27T11:51:55Z

do I right understand that it will always transform package name? e.g. wayland-protocols becomes wayland-protocols:i386 or whatever? in that case, it would be breaking for some packages, as wayland-protocols for instance have no arch packages, and it has only wayland-protocols:all.

Yes, you are right. I totally forget the exotic repositories.

Probably we need an opt-out at install to escape the magic

The initial idea was including an option called plataforms, just like AutoToolsBuildEnvironment. When passing the platform dictionary we can replace our customization:

platforms = {"x86_64": "all", "x86": "all"}
installer = SystemPackageTool(tool=AptTool(), settings=self.settings, platforms=platforms)
installer.install("foobar")

OUTPUT: apt-get install -y --no-install-recommends foobar:all

WDYT?

conans/client/tools/system_pm.py

conans/test/unittests/client/tools/system_pm_test.py

memsharded · 2019-05-27T11:55:14Z

conans/client/tools/system_pm.py

@@ -114,6 +116,17 @@ def install(self, packages, update=True, force=False):
            self.update()
        self._install_any(packages)

+    def _parse_packages_arch(self, packages):
+        if self._settings and cross_building(self._settings):
+            _, _, _, host_arch = get_cross_building_settings(self._settings)


I do not fully understand that packages will be installed for the host_arch always, as by definition, the apt-get will be running in the build-machine, not the host. Will this break everything for users with build_requires packages that use SystemPackageTool?

Thinking again, you are right. I thought in the case where someone wants to cross-building some package and need a library from system. But sometimes users need a tool rather a library, which means the arch build.

We could detect if arch is not declared and use build_arch instead. WDYT?

- User is able to specify prefix/suffix according the arch Signed-off-by: Uilian Ries <uilianries@gmail.com>

lasote

It is more confusing that it should, because the idea is very simple. I suggested some changes.

conans/client/tools/system_pm.py

Signed-off-by: Uilian Ries <uilianries@gmail.com>

jgsogo

Just change settings to conanfile in the constructor (and docs), probably it is a better pattern for every tool. It is a problem we already have in the MSBuild class.

lasote · 2019-06-28T10:25:23Z

Good catch @jgsogo . I agree. Please, @uilianries change it so we can merge this.

uilianries · 2019-06-28T12:05:07Z

@jgsogo yeah, it sounds better, we are using such approach for CMake helper.

Signed-off-by: Uilian Ries <uilianries@gmail.com>

uilianries · 2019-06-28T12:22:26Z

@lasote @jgsogo Done, both code and docs are updated with conanfile.

jgsogo

I promise to you this is the last change I request 🤞

conans/client/tools/system_pm.py

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

Signed-off-by: Uilian Ries <uilianries@gmail.com>

lasote · 2019-07-01T10:20:29Z

🎉

uilianries added 2 commits May 24, 2019 17:17

conan-io#5026 Detect package prefix name by settings

c934416

- Each package manages has a specific prefix/suffix to deal with architectures. - Some package managers (e.g brew) do not provide multi-arch support, only an universal option. Signed-off-by: Uilian Ries <uilianries@gmail.com>

conan-io#5026 Validate SystemPackageTool with settings

ca34e73

- Validate yum and apt when installing x86 Signed-off-by: Uilian Ries <uilianries@gmail.com>

uilianries mentioned this pull request May 24, 2019

Update SystemPackageTool to support settings conan-io/docs#1291

Merged

danimtb approved these changes May 27, 2019

View reviewed changes

danimtb added the stage: review label May 27, 2019

lasote added this to the 1.16 milestone May 27, 2019

jgsogo suggested changes May 27, 2019

View reviewed changes

conans/client/tools/system_pm.py Outdated Show resolved Hide resolved

conans/test/unittests/client/tools/system_pm_test.py Show resolved Hide resolved

jgsogo assigned uilianries May 27, 2019

memsharded reviewed May 27, 2019

View reviewed changes

conan-io#5026 Support custom platform

b78d392

- User is able to specify prefix/suffix according the arch Signed-off-by: Uilian Ries <uilianries@gmail.com>

lasote assigned memsharded and unassigned uilianries May 28, 2019

lasote requested changes May 28, 2019

View reviewed changes

conans/client/tools/system_pm.py Outdated Show resolved Hide resolved

conans/client/tools/system_pm.py Outdated Show resolved Hide resolved

conans/client/tools/system_pm.py Outdated Show resolved Hide resolved

SSE4 reviewed May 28, 2019

View reviewed changes

conans/client/tools/system_pm.py Outdated Show resolved Hide resolved

conans/client/tools/system_pm.py Outdated Show resolved Hide resolved

conans/client/tools/system_pm.py Show resolved Hide resolved

lasote modified the milestones: 1.16, 1.17 May 30, 2019

uilianries added 2 commits May 31, 2019 10:30

conan-io#5026 Remove useless code

7addf75

Signed-off-by: Uilian Ries <uilianries@gmail.com>

conan-io#5026 Rename methods for package name

78c7282

Signed-off-by: Uilian Ries <uilianries@gmail.com>

lasote approved these changes Jun 28, 2019

View reviewed changes

jgsogo suggested changes Jun 28, 2019

View reviewed changes

conan-io#5026 Use conanfile for SystemPackageTool

03a7ebe

Signed-off-by: Uilian Ries <uilianries@gmail.com>

jgsogo suggested changes Jun 28, 2019

View reviewed changes

conans/client/tools/system_pm.py Outdated Show resolved Hide resolved

uilianries and others added 2 commits June 28, 2019 10:40

conan-io#5026 Validate output instance

ee0e6c7

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

conan-io#5026 Fix bad indented block

f0a52e9

Signed-off-by: Uilian Ries <uilianries@gmail.com>

lasote merged commit b75300b into conan-io:develop Jul 1, 2019

Croydon mentioned this pull request Feb 19, 2020

Architecture support in SystemPackageTool #1062

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Detect System package name by recipe settings (#5026) #5215

Detect System package name by recipe settings (#5026) #5215

uilianries commented May 24, 2019 •

edited

danimtb left a comment

SSE4 commented May 27, 2019

lasote commented May 27, 2019

uilianries commented May 27, 2019

memsharded May 27, 2019

uilianries May 27, 2019

lasote left a comment

jgsogo left a comment •

edited

lasote commented Jun 28, 2019

uilianries commented Jun 28, 2019

uilianries commented Jun 28, 2019

jgsogo left a comment

lasote commented Jul 1, 2019

Detect System package name by recipe settings (#5026) #5215

Detect System package name by recipe settings (#5026) #5215

Conversation

uilianries commented May 24, 2019 • edited

danimtb left a comment

Choose a reason for hiding this comment

SSE4 commented May 27, 2019

lasote commented May 27, 2019

uilianries commented May 27, 2019

memsharded May 27, 2019

Choose a reason for hiding this comment

uilianries May 27, 2019

Choose a reason for hiding this comment

lasote left a comment

Choose a reason for hiding this comment

jgsogo left a comment • edited

Choose a reason for hiding this comment

lasote commented Jun 28, 2019

uilianries commented Jun 28, 2019

uilianries commented Jun 28, 2019

jgsogo left a comment

Choose a reason for hiding this comment

lasote commented Jul 1, 2019

uilianries commented May 24, 2019 •

edited

jgsogo left a comment •

edited