Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake::msbuild_verbosity can be avoided in the command line #5220

Merged
merged 1 commit into from May 27, 2019

Conversation

@jgsogo
Copy link
Member

@jgsogo jgsogo commented May 27, 2019

Changelog: Fix: Add the ability to avoid the /verbosity argument in CMake command line for MSBuild
Docs: conan-io/docs#1292

closes #5216

The user can avoid the /verbosity argument by using msbuild_verbosity=None in the CMake constructor. Previously this value was setting /verbosity:minimal.


⚠️ This PR only breaks the use case where the recipe is creating CMake helper with an explicit None value for the MSBuild verbosity: CMake(... msbuild_verbosity=None)

  • before, it will translate to the argument /verbosity:minimal.
  • now it will remove the argument /verbosity
@jgsogo jgsogo added this to the 1.16 milestone May 27, 2019
@jgsogo jgsogo changed the title Cmake::msbuild_verbosity can be eluded in the command line Cmake::msbuild_verbosity can be avoided in the command line May 27, 2019
@jgsogo jgsogo requested a review from SSE4 May 27, 2019
SSE4
SSE4 approved these changes May 27, 2019
Copy link
Contributor

@SSE4 SSE4 left a comment

easy as cake!

Loading

@memsharded
Copy link
Member

@memsharded memsharded commented May 27, 2019

⚠️ This PR only breaks the use case where the recipe is creating CMake helper with an explicit None value for the MSBuild verbosity: CMake(... msbuild_verbosity=None)

I am ok with this.

Loading

@memsharded memsharded merged commit d94a3bc into conan-io:develop May 27, 2019
2 checks passed
Loading
@jgsogo jgsogo deleted the issue/5216-cmake-verbosity branch May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants