Fix AutoToolsBuildEnvironment target triple #5283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os_target and arch_target settings were previously not taken into account when automatically populating --target flag for the configure step.
Ignition
force-pushed
the
ATBE-target-fix
branch
2 times, most recently
from
c9ebf89
to
1c389f5
Compare
lasote
approved these changes
Jun 17, 2019
|
Since the new model of cross-building will change some of this stuff (but not breaking), I think for the current model it makes total sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix:
AutoToolsBuildEnvironmentis now aware ofos_targetandarch_targetto calculate the gnu triplet when declared.Docs: omit
Closes #5274.
I've added a simple unittest which runs and passes.