Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AutoToolsBuildEnvironment target triple #5283

Merged
merged 2 commits into from Jun 24, 2019

Conversation

Projects
None yet
2 participants
@Ignition
Copy link
Contributor

commented Jun 3, 2019

Changelog: Fix: AutoToolsBuildEnvironment is now aware of os_target and arch_target to calculate the gnu triplet when declared.
Docs: omit

Closes #5274.
I've added a simple unittest which runs and passes.

AutoToolsBuildEnvironment fix for target triplet
os_target and arch_target settings were previously not taken into
account when automatically populating --target flag for the
configure step.

@Ignition Ignition force-pushed the Ignition:ATBE-target-fix branch 2 times, most recently from c9ebf89 to 1c389f5 Jun 3, 2019

@Ignition Ignition force-pushed the Ignition:ATBE-target-fix branch from 1c389f5 to b6ac16d Jun 3, 2019

@lasote lasote added this to the 1.17 milestone Jun 17, 2019

@lasote

lasote approved these changes Jun 17, 2019

@lasote

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

Since the new model of cross-building will change some of this stuff (but not breaking), I think for the current model it makes total sense.

@lasote lasote merged commit dfe12eb into conan-io:develop Jun 24, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.