Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare sha256 case insensitive #5306

Merged
merged 1 commit into from Jun 6, 2019
Merged

Compare sha256 case insensitive #5306

merged 1 commit into from Jun 6, 2019

Conversation

feliwir
Copy link
Contributor

@feliwir feliwir commented Jun 6, 2019 •
edited by memsharded

Changelog: Bugfix: Use case insensitive comparison for SHA256 checksums
Docs: Omit

Fixes mismatches for the same signature with different case sensitivity e.g.:

Provided signature: C75203EF4759E4D7BC38E686B156C54C43B78EDC73123C0B25DB5224758BD1FC  
Computed signature: c75203ef4759e4d7bc38e686b156c54c43b78edc73123c0b25db5224758bd1fc

@SSE4

@CLAassistant
Copy link

CLAassistant commented Jun 6, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@memsharded memsharded added this to the 1.17 milestone Jun 6, 2019
@memsharded memsharded merged commit 551ddac into conan-io:develop Jun 6, 2019
@memsharded
Copy link
Member

Thanks for contributing this fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.17
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@feliwir @CLAassistant @memsharded