Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make conan_data visible to pylint #5337

Merged
merged 3 commits into from Jun 11, 2019

Conversation

Projects
None yet
2 participants
@uilianries
Copy link
Member

commented Jun 11, 2019

Since Conan 1.16.0 we are able to add a data file called conandata.yml, which can be retrieved by self.conan_data in our recipe. However, that member is lazy and Conan's linter detects it as non-member before exporting.

Changelog: Fix: Make conan_data visible to pylint (#5327)
Docs: Omit

fixes #5327

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

uilianries added some commits Jun 11, 2019

#5327 Add test to reproduce linter error
- Add functional test which include conandata.yml

Signed-off-by: Uilian Ries <uilianries@gmail.com>
#5327 Ignore linter warning for conan_data
Signed-off-by: Uilian Ries <uilianries@gmail.com>

@memsharded memsharded self-assigned this Jun 11, 2019

@memsharded memsharded added this to the 1.17 milestone Jun 11, 2019

#5327 Load conan_data for pylint
Signed-off-by: Uilian Ries <uilianries@gmail.com>

@uilianries uilianries changed the title Ignore linter warning for conan_data Make conan_data visible to pylint Jun 11, 2019

@memsharded memsharded merged commit 10028d9 into conan-io:develop Jun 11, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.