New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove packages when version is asterisk #5346
Remove packages when version is asterisk #5346
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Wait, just |
Version range is okay, it's validated by ConanFileReference. The only problem there is about when only version is |
Actually this error only occurs for |
(Forget my comment about the validation.) This also fails for any pattern with a single
|
@jgsogo Oh, it's true, good catch! I'll update that! thanks |
- Not only version, but also channel and user can contain asterisk Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the suggestion for the if
/else
block
Signed-off-by: Uilian Ries <uilianries@gmail.com>
When removing a pattern like hello/*@conan/testing, Conan doesn't remove all patterns because all fields (name, version, channel, user) are validated by ConanFileReference. However, when using a pattern like hello*/*@conan/testing, the ConanFileReference won't match the name and will search for recipes.
Changelog: Fix: Remove packages when version is asterisk (#5297)
Docs: Omit
fixes #5297
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.