Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip cmake compiler checks when toolset declared #5348

Merged
merged 1 commit into from Jun 12, 2019

Conversation

Projects
None yet
3 participants
@lasote
Copy link
Contributor

commented Jun 12, 2019

Changelog: Fix: Skipped the compiler version check in the cmake generator when a -s compiler.toolset is specified (Visual Studio).
Docs: omit

Close #5343
Reverted #5321

@lasote lasote added this to the 1.16.1 milestone Jun 12, 2019

@lasote lasote requested review from memsharded and uilianries Jun 12, 2019

@uilianries
Copy link
Member

left a comment

LGTM

So if you use a specific toolset version we won't check compiler x toolset version. This will solve that problem, but on the other hand the user is able to do any crazy combination.

@lasote lasote merged commit 6b90307 into conan-io:release/1.16.1 Jun 12, 2019

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.