Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip cmake compiler checks when toolset declared #5348

Merged
merged 1 commit into from Jun 12, 2019
Merged

Skip cmake compiler checks when toolset declared #5348

merged 1 commit into from Jun 12, 2019

Conversation

lasote
Copy link
Contributor

@lasote lasote commented Jun 12, 2019

Changelog: Fix: Skipped the compiler version check in the cmake generator when a -s compiler.toolset is specified (Visual Studio).
Docs: omit

Close #5343
Reverted #5321

@lasote lasote added this to the 1.16.1 milestone Jun 12, 2019
uilianries
uilianries approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

So if you use a specific toolset version we won't check compiler x toolset version. This will solve that problem, but on the other hand the user is able to do any crazy combination.

@lasote lasote merged commit 6b90307 into conan-io:release/1.16.1 Jun 12, 2019
@memsharded memsharded mentioned this pull request Jun 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@memsharded memsharded memsharded approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.16.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lasote @uilianries @memsharded