Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept a list for the requires attribute #5371

Merged
merged 2 commits into from Jun 19, 2019

Conversation

Projects
None yet
3 participants
@jgsogo
Copy link
Member

commented Jun 19, 2019

Changelog: Fix: Accept a list for the requires attribute
Docs: conan-io/docs#1332

closes #5313

Accept a list for the requires attribute, now any of these formats will get the same result:

  • requires = "req/1.0@user/version", "req2/1.0@user/version"
  • requires = ("req/1.0@user/version", "req2/1.0@user/version")
  • requires = ["req/1.0@user/version", "req2/1.0@user/version"]

And also, if you specify the visibility of the requires:

  • requires = (("req/1.0@user/version", "private"), )
  • requires = [("req/1.0@user/version", "private"), ]
@lasote
Copy link
Contributor

left a comment

An integration test is needed. You can probably modify the requirements from an existing one to be a list.

@lasote lasote added this to the 1.17 milestone Jun 19, 2019

@jgsogo

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

I've just changed two random ones

@lasote

lasote approved these changes Jun 19, 2019

@danimtb danimtb merged commit 4a2e7fb into conan-io:develop Jun 19, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@jgsogo jgsogo deleted the jgsogo:issue/5313-requires-list branch Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.