Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old folder for conan install (#5376) #5384

Merged
merged 4 commits into from Jun 28, 2019

Conversation

Projects
None yet
3 participants
@uilianries
Copy link
Member

commented Jun 21, 2019

  • Run rmdir before creating a new temp folder

Changelog: Fix: Remove old folder for conan install (#5376)
Docs: Omit
fixes #5376

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

uilianries added some commits Jun 21, 2019

#5376 Generate unique folder for conan install
- Use current time as folder suffix

Signed-off-by: Uilian Ries <uilianries@gmail.com>
#5376 Generate UUID for config install folder
- Replace current time by UUID.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@lasote
Copy link
Contributor

left a comment

I think it would be better to remove the folder at the beginning if it exists to avoid creating N dirty folders.

@lasote lasote added this to the 1.17 milestone Jun 24, 2019

#5376 Remove temp folder before creating a new one
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@lasote
Copy link
Contributor

left a comment

I think the test can be easier now. Just write a file after the first call and check after the second that the file is not there anymore.

@jgsogo

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

And please, @uilianries , change the changelog according to the behavior.

#5376 Check if there is no temp file
Signed-off-by: Uilian Ries <uilianries@gmail.com>

@uilianries uilianries changed the title Generate unique folder for conan install (#5376) Remove old folder for conan install (#5376) Jun 24, 2019

@uilianries

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

@jgsogo done!

@jgsogo

jgsogo approved these changes Jun 24, 2019

@lasote lasote merged commit 18bbc80 into conan-io:develop Jun 28, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.