Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3575 Validate URLs for remotes #5418

Merged

Conversation

@uilianries
Copy link
Member

@uilianries uilianries commented Jun 28, 2019

  • Only accepts valid URL which contains scheme://hostname when adding or updating a remote.

Changelog: Feature: Show warning when URLs for remotes is invalid (missing schema, host, etc).
Docs: Omit
fixes #3575

- Only accepts valid URL which contains scheme://hostname when adding
  or updating a remote.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Copy link
Member

@memsharded memsharded left a comment

Please do not raise errors, but warnings, and complete the operations

@uilianries
Copy link
Member Author

@uilianries uilianries commented Jun 29, 2019

@memsharded yes, it sounds better. Even inspect being an experimental feature, I think it could break some users.

uilianries added 2 commits Jun 29, 2019
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Copy link
Member

@memsharded memsharded left a comment

Please check the 2 broken tests.
Those tests were passing None to make sure that those servers were not being accessed at all. I think an erroneous string (something that would actually display a warning) would achieve the same purpose of the test.

uilianries added 3 commits Jun 30, 2019
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@lasote lasote added this to the 1.17 milestone Jul 1, 2019
@memsharded memsharded merged commit b56d74f into conan-io:develop Jul 1, 2019
2 checks passed
@uilianries uilianries deleted the hotfix/remote-url-validation branch Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants