Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3575 Validate URLs for remotes #5418

Merged

Conversation

Projects
None yet
3 participants
@uilianries
Copy link
Member

commented Jun 28, 2019

  • Only accepts valid URL which contains scheme://hostname when adding or updating a remote.

Changelog: Feature: Show warning when URLs for remotes is invalid (missing schema, host, etc).
Docs: Omit
fixes #3575

#3575 Valid URL for remotes
- Only accepts valid URL which contains scheme://hostname when adding
  or updating a remote.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
#3575 Fix broken tests
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@memsharded
Copy link
Contributor

left a comment

Please do not raise errors, but warnings, and complete the operations

@uilianries

This comment has been minimized.

Copy link
Member Author

commented Jun 29, 2019

@memsharded yes, it sounds better. Even inspect being an experimental feature, I think it could break some users.

uilianries added some commits Jun 29, 2019

#3575 Warning invalid URL
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@memsharded
Copy link
Contributor

left a comment

Please check the 2 broken tests.
Those tests were passing None to make sure that those servers were not being accessed at all. I think an erroneous string (something that would actually display a warning) would achieve the same purpose of the test.

uilianries added some commits Jun 30, 2019

#3575 Warning when remote is null
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#3575 Only valid URL with content
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#3575 Warning when URL is empty
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#3575 Check remote list
Signed-off-by: Uilian Ries <uilianries@gmail.com>

@lasote lasote added this to the 1.17 milestone Jul 1, 2019

@memsharded memsharded merged commit b56d74f into conan-io:develop Jul 1, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@uilianries uilianries deleted the uilianries:hotfix/remote-url-validation branch Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.