Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3575 Validate URLs for remotes #5418

Merged
merged 8 commits into from Jul 1, 2019
Merged

#3575 Validate URLs for remotes #5418

merged 8 commits into from Jul 1, 2019

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Jun 28, 2019 •
edited by lasote

  • Only accepts valid URL which contains scheme://hostname when adding or updating a remote.

Changelog: Feature: Show warning when URLs for remotes is invalid (missing schema, host, etc).
Docs: Omit
fixes #3575

@uilianries
conan-io#3575 Valid URL for remotes
12df2ab 
- Only accepts valid URL which contains scheme://hostname when adding
  or updating a remote.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries mentioned this pull request Jun 28, 2019
Closed
@uilianries
conan-io#3575 Fix broken tests
b372dfb 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
memsharded
memsharded requested changes Jun 29, 2019
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not raise errors, but warnings, and complete the operations

@uilianries
Copy link
Member Author

@memsharded yes, it sounds better. Even inspect being an experimental feature, I think it could break some users.

@uilianries
Revert "conan-io#3575 Fix broken tests"
ae51102 
This reverts commit b372dfb.
@uilianries
conan-io#3575 Warning invalid URL
60b78d8 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
memsharded
memsharded requested changes Jun 30, 2019
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the 2 broken tests.
Those tests were passing None to make sure that those servers were not being accessed at all. I think an erroneous string (something that would actually display a warning) would achieve the same purpose of the test.

@uilianries
conan-io#3575 Warning when remote is null
cc66a45 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
conan-io#3575 Only valid URL with content
892821e 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
conan-io#3575 Warning when URL is empty
aac437a 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
conan-io#3575 Check remote list
fc7eb12 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@lasote lasote added this to the 1.17 milestone Jul 1, 2019
@memsharded memsharded merged commit b56d74f into conan-io:develop Jul 1, 2019
@uilianries uilianries deleted the hotfix/remote-url-validation branch July 1, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.17
Development

Successfully merging this pull request may close these issues.

[Commands] Validate remote URL
3 participants
@uilianries @memsharded @lasote