Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-dateutil>=2.7.0 is required for dateutil.parser.isoparse #5485

Conversation

@vector-of-bool
Copy link
Contributor

commented Jul 12, 2019

Changelog: Bugfix: Update python-dateutil dependency to ensure availability of dateutil.parser.isoparse

Docs: Omit

  • Closes: #5484.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Do you want a docs PR for this one? I feel like this one will be very rarely hit.

@CLAassistant

This comment has been minimized.

Copy link

commented Jul 12, 2019

CLA assistant check
All committers have signed the CLA.

@memsharded memsharded added this to the 1.17.1 milestone Jul 13, 2019

@memsharded

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2019

Thanks very much for reporting and fixing this issue.

As this is a bug, and apparently no much people is hitting it, it seems that we could increase that minimum version safely, I am proposing it for the 1.17.1 minor release, lets wait for @lasote feedback.

@lasote

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

Yes, This should go to the 1.17.1. Thanks. @vector-of-bool could you open the branch from release/1.17.1 and add the change? We can do it otherwise.

@memsharded

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

@vector-of-bool

No, no docs needed for this, thanks, I have just updated your comment to Docs: Omit.

@vector-of-bool vector-of-bool force-pushed the vector-of-bool:feature/fix-dateutil-isoparse-dep-version branch from 81fade5 to d5544d6 Jul 15, 2019

@vector-of-bool vector-of-bool changed the base branch from develop to release/1.17.1 Jul 15, 2019

@vector-of-bool

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

I've rebased onto release/1.17.1

@memsharded

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

Many thanks.

@memsharded memsharded merged commit 71d4e52 into conan-io:release/1.17.1 Jul 15, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@vector-of-bool vector-of-bool deleted the vector-of-bool:feature/fix-dateutil-isoparse-dep-version branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.