Better ref representation #5509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Jul 18, 2019
| @@ -72,7 +72,7 @@ def _file_document(name, path): | |||
| def log_recipe_upload(ref, duration, files_uploaded, remote_name): | |||
| files_uploaded = files_uploaded or {} | |||
| files_uploaded = [_file_document(name, path) for name, path in files_uploaded.items()] | |||
| _append_action("UPLOADED_RECIPE", {"_id": str(ref), | |||
| _append_action("UPLOADED_RECIPE", {"_id": repr(ref.copy_clear_rev()), | |||
There was a problem hiding this comment.
Annotate to add revision info for Conan 2.0. The traces should be complete, including the revision, right?
|
CI errored in spurious typical error. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Incomplete references (for local conanfile.py files) are not printed with
@None/Noneanymore.Docs: omit
repr(ref)as the python recommends, is the complete representation of a reference, including the "None" if they are there.str(ref)is the "print" representation, it omits theNoneuser and channel if present, without revisionsref.full_str()is introduced to nicely print a reference with revisionsfull_repr()has been removed, by definitionreprshould be always "full".str(ref)that was used internally in data structures, e.g, dict keys, has been replacing (compatibility) withrepr(ref.copy_clear_rev())because the meaning is more correct.@PYVERS: Macos@py27, Windows@py36, Linux@py27, py34
@tags: svn, slow
@revisions: 1