Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better ref representation #5509

Merged
merged 2 commits into from Jul 19, 2019
Merged

Conversation

@lasote
Copy link
Contributor

@lasote lasote commented Jul 18, 2019

Changelog: Fix: Incomplete references (for local conanfile.py files) are not printed with @None/None anymore.
Docs: omit

  • Preparation for the PR about omitting user and channel
  • Improved representation of references:
    • repr(ref) as the python recommends, is the complete representation of a reference, including the "None" if they are there.
    • str(ref) is the "print" representation, it omits the None user and channel if present, without revisions
    • a method ref.full_str() is introduced to nicely print a reference with revisions
    • The full_repr() has been removed, by definition repr should be always "full".
    • Some str(ref) that was used internally in data structures, e.g, dict keys, has been replacing (compatibility) with repr(ref.copy_clear_rev()) because the meaning is more correct.

@PYVERS: Macos@py27, Windows@py36, Linux@py27, py34
@tags: svn, slow
@revisions: 1

@lasote lasote requested a review from memsharded Jul 18, 2019
@lasote lasote added this to the 1.18 milestone Jul 18, 2019
@@ -72,7 +72,7 @@ def _file_document(name, path):
def log_recipe_upload(ref, duration, files_uploaded, remote_name):
files_uploaded = files_uploaded or {}
files_uploaded = [_file_document(name, path) for name, path in files_uploaded.items()]
_append_action("UPLOADED_RECIPE", {"_id": str(ref),
_append_action("UPLOADED_RECIPE", {"_id": repr(ref.copy_clear_rev()),
Copy link
Member

@memsharded memsharded Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annotate to add revision info for Conan 2.0. The traces should be complete, including the revision, right?

Loading

@lasote
Copy link
Contributor Author

@lasote lasote commented Jul 19, 2019

CI errored in spurious typical error. Merging.

Loading

@lasote lasote merged commit db69f8c into conan-io:develop Jul 19, 2019
1 of 2 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants