Fixed GCC 5 warn about libcxx and tests #5524
Merged
+16
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasote
commented
Jul 22, 2019
| @@ -12,11 +12,6 @@ class ProfileTest(unittest.TestCase): | |||
| def reuse_output_test(self): | |||
| client = TestClient() | |||
| client.run("profile new myprofile --detect") | |||
|
|
|||
| if "WARNING: GCC OLD ABI COMPATIBILITY" in client.out: | |||
There was a problem hiding this comment.
I think this assert is repeated (in the following test), so I removed it.
lasote
commented
Jul 22, 2019
| @@ -75,8 +70,9 @@ def profile_update_and_get_test(self): | |||
| client = TestClient() | |||
| client.run("profile new ./MyProfile --detect") | |||
| if "WARNING: GCC OLD ABI COMPATIBILITY" in client.out: | |||
| self.assertIn("edit the MyProfile profile at", client.out) | |||
| self.assertIn(os.path.join(client.current_folder, "MyProfile"), client.out) | |||
| self.assertIn("Or edit '{}/MyProfile' and " | |||
There was a problem hiding this comment.
The output changed some time ago to contain the abs path, but the test was never failing in CI because of the bug with the major version of the GCC, the if "WARNING: GCC OLD ABI COMPATIBILITY" in client.out: was never true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: When a profile was detected, for GCC 5.X the warning message about the default
libcxxwas not shown.Docs: omit
When GCC == 5.X, the comparison
if Version(version) >= Version("5.1"):was never true, becauseversionhad always the major version only. In CI the GCC version is5.3, so the tests were never doing the assert because the warning was never printed.