Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed GCC 5 warn about libcxx and tests #5524

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@lasote
Copy link
Contributor

commented Jul 22, 2019

Changelog: Bugfix: When a profile was detected, for GCC 5.X the warning message about the default libcxx was not shown.
Docs: omit

When GCC == 5.X, the comparison if Version(version) >= Version("5.1"): was never true, because version had always the major version only. In CI the GCC version is 5.3, so the tests were never doing the assert because the warning was never printed.

@lasote lasote added this to the 1.17.1 milestone Jul 22, 2019

@lasote lasote requested a review from memsharded Jul 22, 2019

@@ -12,11 +12,6 @@ class ProfileTest(unittest.TestCase):
def reuse_output_test(self):
client = TestClient()
client.run("profile new myprofile --detect")

if "WARNING: GCC OLD ABI COMPATIBILITY" in client.out:

This comment has been minimized.

Copy link
@lasote

lasote Jul 22, 2019

Author Contributor

I think this assert is repeated (in the following test), so I removed it.

@@ -75,8 +70,9 @@ def profile_update_and_get_test(self):
client = TestClient()
client.run("profile new ./MyProfile --detect")
if "WARNING: GCC OLD ABI COMPATIBILITY" in client.out:
self.assertIn("edit the MyProfile profile at", client.out)
self.assertIn(os.path.join(client.current_folder, "MyProfile"), client.out)
self.assertIn("Or edit '{}/MyProfile' and "

This comment has been minimized.

Copy link
@lasote

lasote Jul 22, 2019

Author Contributor

The output changed some time ago to contain the abs path, but the test was never failing in CI because of the bug with the major version of the GCC, the if "WARNING: GCC OLD ABI COMPATIBILITY" in client.out: was never true.

@memsharded memsharded merged commit 7c433ad into conan-io:release/1.17.1 Jul 22, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.