conan search <pattern> --revisions with cache Issue/5472 #5537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasote
requested changes
Jul 26, 2019
There was a problem hiding this comment.
- There are no tests: Test the feature, test the --revisions with --remote and not ref
- I suspect that the search.py will crash for editable packages when gathering the revision?
- I would avoid passing the
with_revisionargument, thesearch_recipescould return always a reference with the revision filled (if any). So the "print_revision" argument would be enough.
lasote
requested changes
Jul 29, 2019
There was a problem hiding this comment.
I would try to make the local search return the revisions always, I think it should simplify the things and doesn't look very dangerous: https://github.com/conan-io/conan/compare/develop...lasote:delete/test_search?expand=1
| @@ -1194,6 +1194,10 @@ class Test(ConanFile): | |||
| client.run("search lib/1.0@user/testing --revisions") | |||
| self.assertIn("bd761686d5c57b31f4cd85fd0329751f (No time)", client.out) | |||
|
|
|||
| # test that the pattern search with --revisions enabled works | |||
| client.run("search li* --revisions") | |||
| self.assertIn("bd761686d5c57b31f4cd85fd0329751f (No time)", client.out) | |||
There was a problem hiding this comment.
Is it lib/1.0@user/testing#bd761686d5c57b31f4cd85fd0329751f (No time)? In that case assert the whole line because it is confusing what is bd761686d5c57b31f4cd85fd0329751f
conans/client/conan_api.py
Outdated
| @@ -1093,7 +1093,7 @@ def get_remote_by_name(self, remote_name): | |||
| return self._cache.registry.load_remotes()[remote_name] | |||
|
|
|||
| @api_method | |||
| def get_recipe_revisions(self, reference, remote_name=None): | |||
| def get_recipe_revisions(self, reference, remote_name=None, check_rev_time=True): | |||
There was a problem hiding this comment.
I think we shouldn't change this method. That check_rev_time is a patch.
conans/client/command.py
Outdated
| info = self._conan.search_recipes(args.pattern_or_reference, | ||
| remote_name=args.remote, | ||
| case_sensitive=args.case_sensitive) | ||
| if info["results"]: |
memsharded
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Output current revision from references in local cache when using a pattern
Docs: conan-io/docs#1381
Previous behaviour was that current revision number could only be shown if a reference was
given with the
--revisionsargument but not a pattern.Now you can use a pattern to list the current revision of the references in the local cache.
Closes #5472
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.