MSBuild::build - Take into account 'useEnv' argument from user input #5609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgsogo
changed the title
lasote
reviewed
Aug 19, 2019
| @@ -154,6 +154,8 @@ def get_command(self, project_file, props_file_path=None, targets=None, upgrade_ | |||
|
|
|||
| if use_env: | |||
| command.append('/p:UseEnv=true') | |||
| else: | |||
| command.append('/p:UseEnv=false') | |||
There was a problem hiding this comment.
Mhhh, so the default of the msbuild is /p:UseEnv=true?
There was a problem hiding this comment.
It looks like the default is not true, why we need to put it to false then?
UseEnv property
By default, the platform-specific settings for the current project override the PATH, INCLUDE, LIB, LIBPATH, CONFIGURATION, and PLATFORM environment variables. Set the UseEnv property to true to guarantee that the environment variables are not overridden.
msbuild myProject.vcxproj /p:UseEnv=true
There was a problem hiding this comment.
I get it now. It takes it from the VisualStudioBuildEnvironment
lasote
requested changes
Aug 19, 2019
|
Done |
memsharded
approved these changes
Aug 27, 2019
AKhranovskiy
pushed a commit
to AKhranovskiy/conan
that referenced
this pull request
Sep 2, 2019
…onan-io#5609) * use argument from user input * fix tests * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Use the value of argument
useEnvprovided by the user to theMSBuildhelper also to adjust/p:UseEnv=falsewhen the arg isFalse.Docs: omit
VisualStudioBuildEnvironmentdefaultsuseEnv=True, then if the user calls withMSBuild.build(...., use_env=False,...)the input was not taken into account. This PR complements the functionality introduced in #4655@tags: slow