Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5493 conan get reference is not found #5638

Merged
merged 2 commits into from Sep 13, 2019
Merged

Conversation

@uilianries
Copy link
Member

@uilianries uilianries commented Aug 16, 2019

Changelog: Fix: Show friendly message when can't get remote path
Docs: Omit
fixes: #5493

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Copy link
Contributor

@lasote lasote left a comment

I would say this PR is not fixing anything.
Try to run conan get non-existing/version@user/channel -r conan-center

@lasote lasote added this to the 1.19 milestone Aug 19, 2019
@lasote
Copy link
Contributor

@lasote lasote commented Sep 12, 2019

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member Author

@uilianries uilianries commented Sep 12, 2019

@lasote Indded it was not working. The problem occurred because Bintray returned HTML content, even when we send Accept: application/json. Now it will parse any html content only with the error code and the reason.

I've added a new unit test to validate the method, because I didn't find some way to validate using functional tests. I tried TestClient + TestServer + RequesterMock, but the TestServer is based on Artifactory, which is not affected by json_request. Tell me if you have some idea to implement a functional test.

@lasote
Copy link
Contributor

@lasote lasote commented Sep 13, 2019

Nah, I understand. It is totally ok what you did. Thanks! Now it looks perfect.

@lasote lasote merged commit e3c5916 into conan-io:develop Sep 13, 2019
2 checks passed
@lasote lasote removed their assignment Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants