Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ftp_proxy and all_proxy proxy variables to fix #5683 #5697

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@nicememory
Copy link
Contributor

commented Sep 2, 2019

Changelog: Fix: Excluded also ftp_proxy and all_proxy variables from the environment when proxy configuration is specified in the conan.conf file.
Docs: Omit

Fixes #5683

@CLAassistant

This comment has been minimized.

Copy link

commented Sep 2, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

left a comment

Thanks for your contribution! 🎉

We need you to sign the CLA, and also to fill the first two lines of the PR, changelog will be populated automagically with them. These lines 🔽

image

Fill in the "Changelog" line and, for the docs, you can just use Omit, no docs are needed for this PR.

Thanks

@nicememory

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

I've signed the CLA and filled the PR. I'd like to contribute more to conan, it's awesome!

@lasote lasote added this to the 1.19 milestone Sep 3, 2019
@jgsogo
jgsogo approved these changes Sep 3, 2019
@lasote lasote merged commit 126f915 into conan-io:develop Sep 11, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
@lasote lasote removed their assignment Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.