Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for transitive deps to b2 generator #5812

Merged
merged 1 commit into from Oct 10, 2019

Conversation

@grisumbras
Copy link
Contributor

grisumbras commented Sep 25, 2019

Changelog: Fix: Adds support for transitive dependencies to b2 generator.
Docs: Omit

Fix #5813

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
@grisumbras grisumbras changed the title adds support for transitive deps for b2 generator adds support for transitive deps to b2 generator Sep 25, 2019
@grisumbras grisumbras marked this pull request as ready for review Sep 25, 2019
@lasote

This comment has been minimized.

Copy link
Contributor

lasote commented Sep 25, 2019

@grafikrobot same for this one, could you take a look?

@@ -298,7 +298,7 @@ def b2_test(self):
# mypkg
if $(__define_targets__) {
call-in-project $(mypkg-mod) : lib MyLib1
:
: ''' + '''

This comment has been minimized.

Copy link
@grafikrobot

grafikrobot Sep 29, 2019

Contributor

This looks superfluous.

This comment has been minimized.

Copy link
@grisumbras

grisumbras Sep 30, 2019

Author Contributor

The reason for this change is to protect the trailing space on this line. My editor is configured to remove trailing whitespace on saves. At first I wanted to temporally disable this feature in the editor, but then I thought, that these days it's quite a popular feature, so a different person may inadvertently remove that space character.
The space itself is important, because the respective line in generator's template is : {libs} and produces a trailing space if libs is empty.

This comment has been minimized.

Copy link
@grafikrobot

grafikrobot Sep 30, 2019

Contributor

I see.

@grafikrobot

This comment has been minimized.

Copy link
Contributor

grafikrobot commented Sep 30, 2019

LGTM

@lasote lasote added this to the 1.20 milestone Oct 10, 2019
@lasote lasote merged commit 98dce70 into conan-io:develop Oct 10, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.