adds support for transitive deps to b2 generator #5812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grisumbras
changed the title
|
@grafikrobot same for this one, could you take a look? |
grafikrobot
suggested changes
Sep 29, 2019
| @@ -298,7 +298,7 @@ def b2_test(self): | |||
| # mypkg | |||
| if $(__define_targets__) { | |||
| call-in-project $(mypkg-mod) : lib MyLib1 | |||
| : | |||
| : ''' + ''' | |||
There was a problem hiding this comment.
This looks superfluous.
There was a problem hiding this comment.
The reason for this change is to protect the trailing space on this line. My editor is configured to remove trailing whitespace on saves. At first I wanted to temporally disable this feature in the editor, but then I thought, that these days it's quite a popular feature, so a different person may inadvertently remove that space character.
The space itself is important, because the respective line in generator's template is : {libs} and produces a trailing space if libs is empty.
|
LGTM |
grafikrobot
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Adds support for transitive dependencies to b2 generator.
Docs: Omit
Fix #5813