Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting of server cached capabilities #5880

Merged
merged 3 commits into from Oct 10, 2019

Conversation

@czoido
Copy link
Contributor

czoido commented Oct 8, 2019

Changelog: Bugfix: Artifactory was returning an error on the first login attempt because the server capabilities were not assigned correctly.
Docs: omit

Closes #5878

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@czoido czoido added this to the 1.19.2 milestone Oct 8, 2019
@czoido czoido added the type: bug label Oct 8, 2019
@czoido czoido requested a review from memsharded Oct 8, 2019
@memsharded

This comment has been minimized.

Copy link
Member

memsharded commented Oct 8, 2019

Maybe a test would help, don't know, maybe it is very complicated to do such a test.

@czoido czoido self-assigned this Oct 9, 2019
@lasote lasote self-assigned this Oct 9, 2019
czoido added 2 commits Oct 9, 2019
@czoido czoido requested a review from lasote Oct 9, 2019
@lasote
lasote approved these changes Oct 10, 2019
@lasote lasote merged commit 979e228 into conan-io:release/1.19.2 Oct 10, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
@lasote lasote unassigned lasote and czoido Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.