Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve help for conan remove command #5899

Merged
merged 2 commits into from Oct 14, 2019
Merged

Improve help for conan remove command #5899

merged 2 commits into from Oct 14, 2019

Conversation

sdmg15
Copy link
Contributor

@sdmg15 sdmg15 commented Oct 13, 2019 •
edited by memsharded

Changelog: Fix: Improved conan remove --help message for --packages
Docs: Omit

Fix #5495

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

memsharded
memsharded requested changes Oct 13, 2019
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Please check the comment, the previous was not wrong, the feature is to add that if no argument is passed to --packages all of them are removed.

conans/client/command.py Outdated
@@ -994,7 +994,7 @@ def remove(self, *args):
help="Remove only outdated from recipe packages. "
"This flag can only be used with a reference")
parser.add_argument('-p', '--packages', nargs="*", action=Extender,
help="Select package to remove specifying the package ID")
help="Remove all packages of the specified reference")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but the previous one is still valid. --packages=xxxxx will remove that package with the xxxxx ID, and --packages will remove all packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay then I think "Remove all packages of the specified reference if no specific package ID is provided" describe the both ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good

@danimtb danimtb mentioned this pull request Oct 14, 2019
Closed
@memsharded memsharded merged commit dea8dc2 into conan-io:develop Oct 14, 2019
@memsharded
Copy link
Member

Thanks!

@memsharded memsharded added this to the 1.20 milestone Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded Awaiting requested review from memsharded

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.

Improve help for conan remove <ref_or_pattern> -p
3 participants
@sdmg15 @CLAassistant @memsharded