Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve help for conan remove command #5899

Merged
merged 2 commits into from Oct 14, 2019

Conversation

@sdmg15
Copy link
Contributor

sdmg15 commented Oct 13, 2019

Changelog: Fix: Improved conan remove --help message for --packages
Docs: Omit

Fix #5495

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Oct 13, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

memsharded left a comment

Thanks for the contribution!

Please check the comment, the previous was not wrong, the feature is to add that if no argument is passed to --packages all of them are removed.

@@ -994,7 +994,7 @@ def remove(self, *args):
help="Remove only outdated from recipe packages. "
"This flag can only be used with a reference")
parser.add_argument('-p', '--packages', nargs="*", action=Extender,
help="Select package to remove specifying the package ID")
help="Remove all packages of the specified reference")

This comment has been minimized.

Copy link
@memsharded

memsharded Oct 13, 2019

Member

This is good, but the previous one is still valid. --packages=xxxxx will remove that package with the xxxxx ID, and --packages will remove all packages.

This comment has been minimized.

Copy link
@sdmg15

sdmg15 Oct 13, 2019

Author Contributor

Okay then I think "Remove all packages of the specified reference if no specific package ID is provided" describe the both ?

This comment has been minimized.

Copy link
@memsharded

memsharded Oct 13, 2019

Member

Yes, good

@sdmg15 sdmg15 requested a review from memsharded Oct 14, 2019
@memsharded memsharded merged commit dea8dc2 into conan-io:develop Oct 14, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
@memsharded

This comment has been minimized.

Copy link
Member

memsharded commented Oct 14, 2019

Thanks!

@memsharded memsharded added this to the 1.20 milestone Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.