avoiding complex search in servers #5960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasote
reviewed
Oct 23, 2019
| @@ -123,7 +123,7 @@ def test_trace_actions(self): | |||
| self.assertEqual(num_post, 2) # 2 get urls | |||
|
|
|||
| num_get = len([it for it in actions if "REST_API_CALL" in it and "GET" in it]) | |||
| self.assertEqual(num_get, 9) | |||
| self.assertEqual(num_get, 10) | |||
There was a problem hiding this comment.
I think this is because in the conan user the ``authenticate needs to do a ping first, to check if the OATH capability is there. I think that could be a bug in the previous implementation:
if OAUTH_TOKEN in self._cached_capabilities.get(self.remote_url, []):But cached_capabilities hadn't been populated, because it is not calling to _get_api()
lasote
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Avoid doing complex
conan search --queryin the server, do them always in the client.Docs: omit
Fix: #4951
#tags: slow