Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoiding complex search in servers #5960

Merged
merged 1 commit into from Oct 23, 2019

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Oct 23, 2019

Changelog: Fix: Avoid doing complex conan search --query in the server, do them always in the client.
Docs: omit

Fix: #4951

#tags: slow

@@ -123,7 +123,7 @@ def test_trace_actions(self):
self.assertEqual(num_post, 2) # 2 get urls

num_get = len([it for it in actions if "REST_API_CALL" in it and "GET" in it])
self.assertEqual(num_get, 9)
self.assertEqual(num_get, 10)
Copy link
Contributor

@lasote lasote Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this?

Copy link
Member Author

@memsharded memsharded Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is because in the conan user the ``authenticate needs to do a ping first, to check if the OATH capability is there. I think that could be a bug in the previous implementation:

if OAUTH_TOKEN in self._cached_capabilities.get(self.remote_url, []):

But cached_capabilities hadn't been populated, because it is not calling to _get_api()

@lasote lasote added this to the 1.20 milestone Oct 23, 2019
lasote
lasote approved these changes Oct 23, 2019
@lasote lasote self-assigned this Oct 23, 2019
@lasote lasote merged commit 435f4e7 into conan-io:develop Oct 23, 2019
2 checks passed
@memsharded memsharded deleted the feature/fix_complex_search branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants