Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cpp_info.name not used in cmake find generators for dependencies #5973

Merged
merged 3 commits into from Oct 28, 2019

Conversation

@danimtb
Copy link
Member

danimtb commented Oct 25, 2019

Changelog: Bugfix: Fix cpp_info.name not used in cmake find generators for dependencies
Docs: omit

  • Refer to the issue that supports this Pull Request: closes #5969
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

#TAGS: slow

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@danimtb danimtb self-assigned this Oct 25, 2019
@danimtb danimtb added this to the 1.19.3 milestone Oct 25, 2019
class Conan(ConanFile):
requires = "hello2/1.0"
generators = "cmake_find_package"

This comment has been minimized.

Copy link
@danimtb

danimtb Oct 25, 2019

Author Member

This test is repeated here just using a different generator, but not sure where to place it to avoid repeating code

This comment has been minimized.

Copy link
@memsharded

memsharded Oct 28, 2019

Member

Don't worry too much, leave it at the moment.

@danimtb danimtb assigned lasote and unassigned danimtb Oct 25, 2019
@SSE4 SSE4 referenced this pull request Oct 26, 2019
4 of 4 tasks complete
@lasote
lasote approved these changes Oct 28, 2019
Copy link
Contributor

lasote left a comment

I would say the test improvements can be done later to develop to speed up the minor release.

'exports_sources = "src/*"\n requires = "hello/1.0"',
output=client.out)
client.run("create .")
cmakelists = """

This comment has been minimized.

Copy link
@memsharded

memsharded Oct 28, 2019

Member

No need to change it now, we need to do the release. But for the future, please try to use textwrap.dedent() for cleaner tests layout.

class Conan(ConanFile):
requires = "hello2/1.0"
generators = "cmake_find_package"

This comment has been minimized.

Copy link
@memsharded

memsharded Oct 28, 2019

Member

Don't worry too much, leave it at the moment.

@lasote lasote merged commit 72f6f93 into conan-io:release/1.19.3 Oct 28, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
@Croydon Croydon referenced this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.