Fix cpp_info.name not used in cmake find generators for dependencies #5973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danimtb
commented
Oct 25, 2019
|
|
||
| class Conan(ConanFile): | ||
| requires = "hello2/1.0" | ||
| generators = "cmake_find_package" |
There was a problem hiding this comment.
This test is repeated here just using a different generator, but not sure where to place it to avoid repeating code
There was a problem hiding this comment.
Don't worry too much, leave it at the moment.
4 tasks
lasote
approved these changes
Oct 28, 2019
memsharded
approved these changes
Oct 28, 2019
| 'exports_sources = "src/*"\n requires = "hello/1.0"', | ||
| output=client.out) | ||
| client.run("create .") | ||
| cmakelists = """ |
There was a problem hiding this comment.
No need to change it now, we need to do the release. But for the future, please try to use textwrap.dedent() for cleaner tests layout.
|
|
||
| class Conan(ConanFile): | ||
| requires = "hello2/1.0" | ||
| generators = "cmake_find_package" |
There was a problem hiding this comment.
Don't worry too much, leave it at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Fix
cpp_info.namenot used in cmake find generators for dependenciesDocs: omit
developbranch, documenting this one.#TAGS: slow
Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.