Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/move settings warning #6021

Merged
merged 4 commits into from Nov 19, 2019

Conversation

@Minimonium
Copy link
Contributor

Minimonium commented Nov 4, 2019

Changelog: Fix: Move the warning about mixing 'os' and 'os_build' to just before the pre_export stage
Docs: omit

Closes #4602, #5760, conan-io/hooks#78, conan-io/hooks#77

If required we can move the stdcpp global setting to the same place too. But it depends on the conan info test for some reason:
https://github.com/conan-io/conan/blob/develop/conans/test/functional/settings/cppstd/compiler_cppstd_test.py#L133

@lasote lasote requested a review from memsharded Nov 19, 2019
@lasote lasote added this to the 1.21 milestone Nov 19, 2019
@lasote

This comment has been minimized.

Copy link
Contributor

lasote commented Nov 19, 2019

@memsharded please take a look and let me know WDYT

@lasote

This comment has been minimized.

Copy link
Contributor

lasote commented Nov 19, 2019

@memsharded here is another one but removing directly the warning: #5760

@memsharded memsharded merged commit 9e34842 into conan-io:develop Nov 19, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
@Minimonium Minimonium deleted the Minimonium:feature/move-settings-warning branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.