Feature/move settings warning #6021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@memsharded please take a look and let me know WDYT |
|
@memsharded here is another one but removing directly the warning: #5760 |
memsharded
approved these changes
Nov 19, 2019
This was referenced Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Move the warning about mixing 'os' and 'os_build' to just before the pre_export stage
Docs: omit
Closes #4602, #5760, conan-io/hooks#78, conan-io/hooks#77
If required we can move the
stdcppglobal setting to the same place too. But it depends on theconan infotest for some reason:https://github.com/conan-io/conan/blob/develop/conans/test/functional/settings/cppstd/compiler_cppstd_test.py#L133