Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix issue with apple framewords and CMake cached variables #6042

Merged
merged 6 commits into from Nov 7, 2019

Conversation

@jgsogo
Copy link
Member

jgsogo commented Nov 7, 2019

Changelog: Bugfix: Each Apple framework found using CMake find_library is stored in a different CONAN_FRAMEWORK_<name>_FOUND variable
Docs: omit

Fixes #6035

find_library is not executed if the returning variable to assign already has a value. This PR gives a new name for each variable in the for-loop so the find_library is actually executed for each framework name.

This PR complements #6003

@jgsogo jgsogo added this to the 1.20.3 milestone Nov 7, 2019
@jgsogo jgsogo self-assigned this Nov 7, 2019
@jgsogo jgsogo requested a review from danimtb Nov 7, 2019
@jgsogo jgsogo assigned lasote and unassigned jgsogo Nov 7, 2019
@lasote
lasote approved these changes Nov 7, 2019
Copy link
Contributor

lasote left a comment

Try to add a test with 2 frameworks and see works ok

@danimtb
danimtb approved these changes Nov 7, 2019
@lasote
lasote approved these changes Nov 7, 2019
jgsogo added 2 commits Nov 7, 2019
@danimtb
danimtb approved these changes Nov 7, 2019
@lasote lasote merged commit a04b5cf into conan-io:release/1.20.3 Nov 7, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
@lasote lasote removed their assignment Nov 11, 2019
@jgsogo jgsogo deleted the jgsogo:bugfix/6035-apple-frameworks branch Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.