Integer based deterministic lockfile ids #6139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I've checked out this PR and installed locally. I certainly won't claim to have done any exhaustive regression tests, but it does seem to work as I was originally hoping when I first heard about lockfiles and it does solve the problem from #6119. |
lasote
changed the title
lasote
approved these changes
Dec 4, 2019
| @@ -13,7 +14,7 @@ | |||
|
|
|||
|
|
|||
| LOCKFILE = "conan.lock" | |||
| LOCKFILE_VERSION = "0.1" | |||
| LOCKFILE_VERSION = "0.2" | |||
|
I just noticed an unfortunate aspect of this change: though it is sorted and it is consistent, it's not sorted "correctly." It's using alphabetical sorting instead of numerical and therefore nodes are printed in order 1 -> 10 -> 2 -> 3 ... Doesn't really matter, but it does look a little funny and was not expected. |
|
I'll try to change that in the next breaking change (version bump) of lockfiles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Make lockfiles invariant when the graph doesn't change. Now 2 different lockfiles captured with the same resulting graph in 2 different instants will be identical.
Docs: Omit
Close #6119