Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing pylint from conan codebase. #6152

Merged
merged 14 commits into from Dec 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions conans/client/cmd/export.py
Expand Up @@ -4,7 +4,6 @@

import six

from conans.client.cmd.export_linter import conan_linter
from conans.client.file_copier import FileCopier
from conans.client.output import Color, ScopedOutput
from conans.client.remover import DiskRemover
Expand Down Expand Up @@ -102,7 +101,6 @@ def cmd_export(app, conanfile_path, name, version, user, channel, keep_source,
logger.debug("EXPORT: %s" % conanfile_path)

output.highlight("Exporting package recipe")
conan_linter(conanfile_path, output)
output = conanfile.output

# Get previous digest
Expand Down
86 changes: 0 additions & 86 deletions conans/client/cmd/export_linter.py

This file was deleted.

5 changes: 0 additions & 5 deletions conans/client/conf/__init__.py
Expand Up @@ -123,9 +123,7 @@
# verbose_traceback = False # environment CONAN_VERBOSE_TRACEBACK
# error_on_override = False # environment CONAN_ERROR_ON_OVERRIDE
# bash_path = "" # environment CONAN_BASH_PATH (only windows)
# recipe_linter = False # environment CONAN_RECIPE_LINTER
# read_only_cache = True # environment CONAN_READ_ONLY_CACHE
# pylintrc = path/to/pylintrc_file # environment CONAN_PYLINTRC
# cache_no_locks = True # environment CONAN_CACHE_NO_LOCKS
# user_home_short = your_path # environment CONAN_USER_HOME_SHORT
# use_always_short_paths = False # environment CONAN_USE_ALWAYS_SHORT_PATHS
Expand Down Expand Up @@ -206,16 +204,13 @@ def env_vars(self):
"CONAN_COMPRESSION_LEVEL": self._env_c("general.compression_level", "CONAN_COMPRESSION_LEVEL", "9"),
"CONAN_NON_INTERACTIVE": self._env_c("general.non_interactive", "CONAN_NON_INTERACTIVE", "False"),
"CONAN_SKIP_BROKEN_SYMLINKS_CHECK": self._env_c("general.skip_broken_symlinks_check", "CONAN_SKIP_BROKEN_SYMLINKS_CHECK", "False"),
"CONAN_PYLINTRC": self._env_c("general.pylintrc", "CONAN_PYLINTRC", None),
"CONAN_CACHE_NO_LOCKS": self._env_c("general.cache_no_locks", "CONAN_CACHE_NO_LOCKS", "False"),
"CONAN_PYLINT_WERR": self._env_c("general.pylint_werr", "CONAN_PYLINT_WERR", None),
"CONAN_SYSREQUIRES_SUDO": self._env_c("general.sysrequires_sudo", "CONAN_SYSREQUIRES_SUDO", "False"),
"CONAN_SYSREQUIRES_MODE": self._env_c("general.sysrequires_mode", "CONAN_SYSREQUIRES_MODE", "enabled"),
"CONAN_REQUEST_TIMEOUT": self._env_c("general.request_timeout", "CONAN_REQUEST_TIMEOUT", None),
"CONAN_RETRY": self._env_c("general.retry", "CONAN_RETRY", None),
"CONAN_RETRY_WAIT": self._env_c("general.retry_wait", "CONAN_RETRY_WAIT", None),
"CONAN_VS_INSTALLATION_PREFERENCE": self._env_c("general.vs_installation_preference", "CONAN_VS_INSTALLATION_PREFERENCE", None),
"CONAN_RECIPE_LINTER": self._env_c("general.recipe_linter", "CONAN_RECIPE_LINTER", "True"),
"CONAN_CPU_COUNT": self._env_c("general.cpu_count", "CONAN_CPU_COUNT", None),
"CONAN_READ_ONLY_CACHE": self._env_c("general.read_only_cache", "CONAN_READ_ONLY_CACHE", None),
"CONAN_USER_HOME_SHORT": self._env_c("general.user_home_short", "CONAN_USER_HOME_SHORT", None),
Expand Down
10 changes: 10 additions & 0 deletions conans/pylint_plugin.py
Expand Up @@ -45,3 +45,13 @@ def transform_conanfile(node):
MANAGER.register_transform(
astroid.ClassDef, transform_conanfile,
lambda node: node.qname() == "conans.model.conan_file.ConanFile")


def _python_requires_member():
return astroid.parse("""
from conans.client.graph.python_requires import ConanPythonRequire
python_requires = ConanPythonRequire()
""")


astroid.register_module_extender(astroid.MANAGER, "conans", _python_requires_member)
5 changes: 0 additions & 5 deletions conans/requirements.txt
Expand Up @@ -8,14 +8,9 @@ fasteners>=0.14.1
six>=1.10.0,<1.13.0
node-semver==0.6.1
distro>=1.0.2, <1.2.0
pylint>=1.9.3, <2.0; python_version < '3'
pylint>=2.0,!=2.3.0; python_version >= '3'
future>=0.16.0, <0.19.0
pygments>=2.0, <3.0
astroid>=1.6.5, <2.0; python_version < '3'
astroid>=2.2.0; python_version >= '3'
deprecation>=2.0, <2.1
tqdm>=4.28.1, <5
Jinja2>=2.3, <3
python-dateutil>=2.7.0, <3
typed-ast<1.4; python_version == '3.4' and platform_system=='Windows'
176 changes: 0 additions & 176 deletions conans/test/functional/command/export_linter_test.py

This file was deleted.