Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify conan_build_info --v2 arguments #6169

Merged
merged 5 commits into from Dec 3, 2019

Conversation

@czoido
Copy link
Contributor

czoido commented Dec 2, 2019

Changelog: Bugfix: Removing --skip-env and --multi-module arguments for conan_build_info --v2. Now the environment is not captured (will be handled by the Artifactory plugin) and recipes and packages are saved as different modules in build info.
Docs: conan-io/docs#1486

This PR simplifies Conan build info creation by always saving the information in different modules for recipes and packages (removes the old --multi-module argument). Also, it will not capture environment information by default (removes the old --skip-env argument because the environment information will be handled by the Jenkins Artifactory plugin once this command is integrated into the plugin).

Closes #6144 by removing the arguments.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@czoido czoido added this to the 1.20.5 milestone Dec 2, 2019
@czoido czoido changed the title Fix and simplify conan_build_info --v2 arguments Simplify conan_build_info --v2 arguments Dec 2, 2019
czoido added 2 commits Dec 2, 2019
@lasote lasote merged commit 6fde5eb into conan-io:release/1.20.5 Dec 3, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
lasote added a commit that referenced this pull request Dec 3, 2019
* change arguments

* use always multimodule

* remove env argument

* remove add_prefix

* fix format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.